Update File Selection Message for Dataset Creation #2962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR improves the user interface by updating the message displayed when a user selects files to create a dataset. Previously, the message read "# files uploaded successfully!" after the files were selected from the local machine. However, based on feedback from @chenlica, the term "uploaded" was found to be misleading, as the files are not yet uploaded to the server at this stage. To clarify the process, this PR changes the wording from "uploaded" to "selected," making it clear that the files have only been chosen locally and have not yet been transferred to the server. Additionally, I added a conditional expression to determine whether to use "file" or "files" based on the count. [Before the change] <img width="711" alt="Screenshot 2024-10-24 at 11 17 02 AM" src="https://github.com/user-attachments/assets/343b0218-d669-4cfd-9175-cf58f362416b"> [After the change] <img width="550" alt="Screenshot 2024-10-24 at 11 20 57 AM" src="https://github.com/user-attachments/assets/55f2f537-6bf7-4136-9957-47c964d08f0e"> --------- Co-authored-by: Kunwoo Park <kunwoopark@dhcp-172-31-218-249.mobile.uci.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the user interface by updating the message displayed when a user selects files to create a dataset. Previously, the message read "# files uploaded successfully!" after the files were selected from the local machine. However, based on feedback from @chenlica, the term "uploaded" was found to be misleading, as the files are not yet uploaded to the server at this stage.
To clarify the process, this PR changes the wording from "uploaded" to "selected," making it clear that the files have only been chosen locally and have not yet been transferred to the server.
Additionally, I added a conditional expression to determine whether to use "file" or "files" based on the count.
[Before the change]
[After the change]
