Fix Issues with Workflow Name and Description Modification #2965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 24, 2024 12:56
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR addresses two issues related to modifying the workflow name and description: 1. Write Access Issue: Previously, when a user with write access tried to modify the workflow name or description, the backend would block the action due to an unnecessary validation check. This PR removes the redundant check, allowing users with write access to update the workflow as expected. 2. Read-Only Access Issue: Users with read-only access were able to modify the workflow name or description in the frontend, but the backend would correctly reject these changes. However, the frontend continued to display the modified values until the page was refreshed, leading to a confusing user experience. This PR improves the frontend logic to revert the workflow name and description to their original state if the backend returns an error, ensuring a more consistent and user-friendly experience. https://github.com/user-attachments/assets/ed6aa9c4-67fe-46f3-8b33-64c68198d82a --------- Co-authored-by: Kunwoo Park <kunwoopark@dhcp-v093-134.mobile.uci.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues related to modifying the workflow name and description:
Write Access Issue: Previously, when a user with write access tried to modify the workflow name or description, the backend would block the action due to an unnecessary validation check. This PR removes the redundant check, allowing users with write access to update the workflow as expected.
Read-Only Access Issue: Users with read-only access were able to modify the workflow name or description in the frontend, but the backend would correctly reject these changes. However, the frontend continued to display the modified values until the page was refreshed, leading to a confusing user experience. This PR improves the frontend logic to revert the workflow name and description to their original state if the backend returns an error, ensuring a more consistent and user-friendly experience.
Screen.Recording.2024-10-24.at.2.25.15.PM.mov