Skip to content

Fix macOS frontend CI disconnecting issue #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yicong-Huang merged 30 commits into from
Oct 26, 2024
Merged

Fix macOS frontend CI disconnecting issue #2968

Yicong-Huang merged 30 commits into from
Oct 26, 2024

Conversation

@Yicong-Huang
Copy link
Contributor

@Yicong-Huang Yicong-Huang commented Oct 25, 2024 •
edited
Loading

This PR includes a few efforts to improve frontend CI on macOS.

  1. Changed macOS CI to run on arm64 arch instead of x64. The is the main cause of disconnecting issue.
  2. Upgraded testing-related packages to the latest:
  3. Fixed many problematic test cases, including:
    • Empty test cases (no it cases).
    • Wrong dependency injection (especially on HttpClient should use HttpClientTestingModule).
    • Wrong global NzMessageModule import.

@Yicong-Huang Yicong-Huang self-assigned this Oct 26, 2024
@Yicong-Huang Yicong-Huang added the dependencies Pull requests that update a dependency file label Oct 26, 2024
aglinxinyuan
aglinxinyuan approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Yicong-Huang Yicong-Huang merged commit fd30d60 into master Oct 26, 2024
@Yicong-Huang Yicong-Huang deleted the yicong-fix-frontend-ci-timeout branch October 26, 2024 23:05
PurelyBlank pushed a commit that referenced this pull request Dec 4, 2024
@Yicong-Huang @PurelyBlank
Fix macOS frontend CI disconnecting issue (#2968)
70334ae 
This PR includes a few efforts to improve frontend CI on macOS.

1. Changed macOS CI to run on arm64 arch instead of x64. The is the main
cause of disconnecting issue.
2. Upgraded testing-related packages to the latest: 
- karma to 6.4.4 (applied a custom fix for Chrome > 128.0.0.0.0 on macOS
arm64, see my post
angular/angular-cli#28271 (comment))
    - jasmine-core to 5.4.0
3. Fixed many problematic test cases, including:
    - Empty test cases (no `it` cases).
- Wrong dependency injection (especially on HttpClient should use
`HttpClientTestingModule`).
    - Wrong global NzMessageModule import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aglinxinyuan aglinxinyuan aglinxinyuan approved these changes

Assignees

@Yicong-Huang Yicong-Huang

Labels

dependencies Pull requests that update a dependency file testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yicong-Huang @aglinxinyuan