Add FileResolver to resolve fileName given by users consistently without depending on userSystemEnabled flag
#2969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbai00
force-pushed
the
jiadong-cut-source-user-sys-dependency
branch
from
976c549 to
6c5d4d7
Compare
Yicong-Huang
requested changes
Oct 26, 2024
...amber/src/main/scala/edu/uci/ics/texera/workflow/common/storage/ScanSourceFileResolver.scala
Outdated
Show resolved
Hide resolved
...amber/src/main/scala/edu/uci/ics/texera/workflow/common/storage/ScanSourceFileResolver.scala
Outdated
Show resolved
Hide resolved
...amber/src/main/scala/edu/uci/ics/texera/workflow/common/storage/ScanSourceFileResolver.scala
Outdated
Show resolved
Hide resolved
...amber/src/main/scala/edu/uci/ics/texera/workflow/common/storage/ScanSourceFileResolver.scala
Outdated
Show resolved
Hide resolved
...mber/src/main/scala/edu/uci/ics/texera/workflow/operators/source/scan/ScanSourceOpDesc.scala
Outdated
Show resolved
Hide resolved
...mber/src/main/scala/edu/uci/ics/texera/workflow/operators/source/scan/ScanSourceOpDesc.scala
Outdated
Show resolved
Hide resolved
Yicong-Huang
approved these changes
Oct 26, 2024
core/amber/src/main/scala/edu/uci/ics/texera/workflow/common/storage/FileResolver.scala
Outdated
Show resolved
Hide resolved
core/amber/src/main/scala/edu/uci/ics/texera/workflow/common/storage/FileResolver.scala
Outdated
Show resolved
Hide resolved
core/amber/src/main/scala/edu/uci/ics/texera/workflow/common/storage/FileResolver.scala
Show resolved
Hide resolved
core/amber/src/main/scala/edu/uci/ics/texera/workflow/common/storage/FileResolver.scala
Outdated
Show resolved
Hide resolved
core/amber/src/main/scala/edu/uci/ics/texera/workflow/common/storage/FileResolver.scala
Show resolved
Hide resolved
core/amber/src/main/scala/edu/uci/ics/texera/workflow/common/storage/FileResolver.scala
Outdated
Show resolved
Hide resolved
bobbai00
changed the title
file:// prefix to file that is in the dataset to distinguish with local fileFileResolver to resolve fileName given by users consistently without depending on userSystemEnabled flag
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
…thout depending on userSystemEnabled flag (#2969) This PR changes the logic of scan source operator resolving a file. Specifically, scan source operator now no longer depends on `userSystemEnabled` flag to decide if it is scanning a local file or a file from dataset. Instead, the resolving logic is: Input: fileName (user friendly name provided by the user when setting scan source operators) - check if the file pointed by the fileName exist locally - If exists, resolve it as a local file - if not, check if the file exist in the dataset - if exists, resolve it as a DatasetFileDocument(the file handle of the dataset file) - if not, throw `SourceFileNotFound` error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logic of scan source operator resolving a file.
Specifically, scan source operator now no longer depends on
userSystemEnabledflag to decide if it is scanning a local file or a file from dataset.Instead, the resolving logic is:
Input: fileName (user friendly name provided by the user when setting scan source operators)
SourceFileNotFounderror