Skip to content

Conversation

@bobbai00
Copy link
Contributor

This PR refactors the API of downloading a version of a dataset. The purpose of this refactoring is for future's refactor PRs, like #2972 .

New API

GET /version-zip

  • did: dataset's ID. must be provided, specify which dataset
  • dvid: dataset version's ID, optional. If provided, retrieve this version; otherwise, retrieve the latest version.

@bobbai00 bobbai00 added the refactor Refactor the code label Oct 28, 2024
@bobbai00 bobbai00 requested a review from kunwp1 October 28, 2024 05:54
@bobbai00 bobbai00 self-assigned this Oct 28, 2024
@bobbai00 bobbai00 changed the title Refactor downloading dataset's version feature Refactor downloading dataset version's API Oct 28, 2024
Copy link
Contributor

@kunwp1 kunwp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobbai00 bobbai00 merged commit f7a1ac2 into master Oct 28, 2024
@bobbai00 bobbai00 deleted the jiadong-refine-dataset-download branch October 28, 2024 16:03
PurelyBlank pushed a commit that referenced this pull request Dec 4, 2024
This PR refactors the API of downloading a version of a dataset. The
purpose of this refactoring is for future's refactor PRs, like #2972 .

### New API

GET `/version-zip`
- did: dataset's ID. must be provided, specify which dataset
- dvid: dataset version's ID, optional. If provided, retrieve this
version; otherwise, retrieve the latest version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactor the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants