Fetch the file's size from PhysicalFileNode instead of reading from the file system #2974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunwp1
requested changes
Oct 28, 2024
...main/scala/edu/uci/ics/texera/web/resource/dashboard/user/dataset/type/DatasetFileNode.scala
Outdated
Show resolved
Hide resolved
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
…he file system (#2974) This PR fixes the size retrieving when constructing the DatasetFileNode. As `PhysicalFileNode` already has the file size, this file size will be directly reused, instead of using file system's API to read the size. The bug that, when deleting some files to create a new dataset version, the old version's file tree cannot retrieved correctly because the code tries to retrieve the file size using file system's API, but the file does not physically exist anymore. --------- Co-authored-by: Chris <143021053+kunwp1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the size retrieving when constructing the DatasetFileNode. As
PhysicalFileNodealready has the file size, this file size will be directly reused, instead of using file system's API to read the size.The bug that, when deleting some files to create a new dataset version, the old version's file tree cannot retrieved correctly because the code tries to retrieve the file size using file system's API, but the file does not physically exist anymore.