Refactor the logic of showing selected dataset and version in scan source operators. #2975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
do we disable duplicate database name and version name? |
Contributor
Author
The uniqueness guarantee is the following:
|
bobbai00
force-pushed
the
jiadong-fix-scan-op-file-retrieval
branch
from
3eab960 to
b2bf9e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines the logic of showing selected dataset and version in scan source operators, if a file path is being selected.
It makes it no longer rely on the backend's API, a cleaner implementation. This is the base of the following refactor PR like #2972