Skip to content

Remove scrollbar in workflow workspace #2976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sixsage merged 1 commit into from
Oct 28, 2024
Merged

Remove scrollbar in workflow workspace #2976

sixsage merged 1 commit into from
Oct 28, 2024

Conversation

@sixsage
Copy link
Contributor

@sixsage sixsage commented Oct 28, 2024

Purpose

Remove scrollbar bug in the workflow workspace

Changes

Remove display: block for left panel
Change spinner-container height from 100vh to 100%

Demo

Before
image
After
image

@sixsage sixsage self-assigned this Oct 28, 2024
@sixsage sixsage marked this pull request as ready for review October 28, 2024 11:56
@sixsage sixsage requested a review from aglinxinyuan October 28, 2024 11:56
aglinxinyuan
aglinxinyuan approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sixsage sixsage merged commit 961c468 into master Oct 28, 2024
@sixsage sixsage deleted the fix-workflow-scrollbar branch October 28, 2024 12:33
PurelyBlank pushed a commit that referenced this pull request Dec 4, 2024
@sixsage @PurelyBlank
Remove scrollbar in workflow workspace (#2976)
9e17c2d 
## Purpose
Remove scrollbar bug in the workflow workspace
## Changes
Remove display: block for left panel
Change spinner-container height from 100vh to 100%
## Demo
Before

![image](https://github.com/user-attachments/assets/a66c9b34-48fd-4f3b-8dc0-264c4c151bd8)
After

![image](https://github.com/user-attachments/assets/be39176b-2a64-40a5-baf7-6bef3d86ec64)
@Yicong-Huang Yicong-Huang added frontend Changes related to the frontend GUI and removed gui labels Jul 6, 2025
@Yicong-Huang Yicong-Huang removed the bug label Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aglinxinyuan aglinxinyuan aglinxinyuan approved these changes

Assignees

@sixsage sixsage

Labels

fix frontend Changes related to the frontend GUI starter-task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sixsage @aglinxinyuan @Yicong-Huang