Add ReadonlyVirtualDocument and ReadonlyLocalFileDocument #2978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yicong-Huang
approved these changes
Oct 28, 2024
Contributor
Yicong-Huang
left a comment
Yicong-Huang
left a comment
There was a problem hiding this comment.
The fact that many base APIs are left unimplemented and the generic type provided is Nothing indicate that the base APIs of document is not suiting the design. From offline discussion, we can merge this PR to unblock the separation, but should left TODO clearly on how to break the base Document into readonly, writeonly and iterable traits, and let different documents implement those traits selectively.
Approving this PR per the offline discussion.
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR introduces the abstraction of a read-only resource document, and an implementation representing a read-only local file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the abstraction of a read-only resource document, and an implementation representing a read-only local file.