Fix Frontend Issue With Compute Unit Termination UI #3209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbai00
approved these changes
Jan 14, 2025
| val icebergTableCommitNumRetries: Int = conf.getInt("storage.iceberg.table.commit.retry.num-retries") | ||
| val icebergTableCommitMinRetryWaitMs: Int = conf.getInt("storage.iceberg.table.commit.retry.min-wait-ms") | ||
| val icebergTableCommitMaxRetryWaitMs: Int = conf.getInt("storage.iceberg.table.commit.retry.max-wait-ms") | ||
| val icebergTableCommitNumRetries: Int = |
Contributor
There was a problem hiding this comment.
can you avoid these changes?
Contributor
Author
There was a problem hiding this comment.
Yes, I can avoid these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR overview
Previously, when terminating a computing unit, the request would go through and return correctly. However, the UI notification displays incorrect message. The fix was in the "workflow-computing-unit-managing-service" where the response returned in was in json format.
Video showing change
Screen.Recording.2025-01-13.at.4.10.59.PM.mov