-
Notifications
You must be signed in to change notification settings - Fork 113
chore(deps): bump @babel/helpers from 7.25.7 to 7.28.4 in /core/gui #3795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump @babel/helpers from 7.25.7 to 7.28.4 in /core/gui #3795
Conversation
Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.25.7 to 7.28.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.28.4/packages/babel-helpers) --- updated-dependencies: - dependency-name: "@babel/helpers" dependency-version: 7.28.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
|
@kunwp1, please review the PR. |
|
For this library, our frontend code doesn’t use it directly. Instead, Angular and Nx rely on it indirectly to ensure TypeScript compiles into browser-compatible code. In this case, is there a protocol or systematic way to check for regressions? Do you think running CI tests (frontend unit tests) is sufficient? |
|
Running the unit tests locally, building and running Texera on your machine, and testing a few key functionalities in the Hub and Workflow Editor should be sufficient. |
|
I think we should have clear guidelines on which key features of Texera need to be tested manually. Since Texera has a lot of features, I don’t want to risk overlooking something important during this review process and encountering issues later. |
We can decide that later. For this PR, since the library is frontend-only, you only need to verify the key frontend features. Please test the following: |
|
Thanks! I'll review the PR based on the list |
kunwp1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested all the key features.
Bumps @babel/helpers from 7.25.7 to 7.28.4.
Release notes
Sourced from
@babel/helpers's releases.... (truncated)
Changelog
Sourced from
@babel/helpers's changelog.... (truncated)
Commits
35055e3v7.28.418d88b8Improve@babel/coretypings (#17471)ef155f5v7.28.3741cbd2chore: fix various typos across codebase (#17476)cac0ff4v7.28.2f743094fix:regeneratorDefinecompatibility with es5 strict mode (#17441)baa4cb8v7.27.6fdbf1b3fix:finallycauses unexpected return value (#17366)7d06930v7.27.45b9468dReduceregeneratorsize more (#17287)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.