feat(ui): add pagination and search for wide-column tables #4086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that the result panel trying to show it and schema propagation are going so slow it crashes the system
…and right column shift, and a search bar
github-actions
bot
added
engine
frontend
Contributor
|
@kunwp1 Please review this PR. Check if test cases are needed. I will also review it. |
…7Ball/texera into Ball-FileUpload-WorkingWithFatTables
Contributor
|
I suggest to add @aglinxinyuan to review the UI change. |
kunwp1
requested changes
Dec 1, 2025
Contributor
kunwp1
left a comment
kunwp1
left a comment
There was a problem hiding this comment.
I left a few comments. Also, please add a video or screenshot of the UI change on the PR description.
...rc/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.html
Outdated
Show resolved
Hide resolved
...rc/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.html
Outdated
Show resolved
Hide resolved
amber/src/main/scala/org/apache/texera/web/service/ExecutionResultService.scala
Outdated
Show resolved
Hide resolved
...-operator/src/main/scala/org/apache/amber/operator/source/scan/csv/CSVScanSourceOpDesc.scala
Outdated
Show resolved
Hide resolved
...-operator/src/main/scala/org/apache/amber/operator/source/scan/csv/CSVScanSourceOpExec.scala
Outdated
Show resolved
Hide resolved
...kflow-core/src/main/scala/org/apache/amber/core/storage/result/iceberg/IcebergDocument.scala
Outdated
Show resolved
Hide resolved
...ore/src/main/scala/org/apache/texera/amber/core/storage/result/iceberg/IcebergDocument.scala
Show resolved
Hide resolved
common/workflow-core/src/main/scala/org/apache/amber/core/storage/model/VirtualDocument.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
Contributor
kunwp1
approved these changes
Dec 22, 2025
Contributor
kunwp1
left a comment
kunwp1
left a comment
There was a problem hiding this comment.
Looks good! I added some minor comments. Once you address them, @aglinxinyuan can have a second pass to review the UI.
...core/src/main/scala/org/apache/texera/amber/core/storage/model/ReadonlyVirtualDocument.scala
Show resolved
Hide resolved
.../src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.ts
Show resolved
Hide resolved
…param in getRange(...) and made the column limit displayed on the result panel a configurable parameter
aglinxinyuan
approved these changes
Dec 29, 2025
Contributor
aglinxinyuan
left a comment
aglinxinyuan
left a comment
There was a problem hiding this comment.
LGTM! Left mirror comments.
frontend/src/app/workspace/component/result-panel/result-panel.component.ts
Show resolved
Hide resolved
...rc/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.html
Show resolved
Hide resolved
Contributor
|
@Ma77Ball Please let us know after you have addressed all the comments. Then we can merge this PR. |
Contributor
|
We can merge it after fixing the format. |
Contributor
|
@carloea2 Please do as suggested. |
Contributor
Hello, sorry what should I do? |
Contributor
Contributor
Author
|
I already fixed the format @aglinxinyuan or @kunwp1, please approve the workflows to move forward with merging this pr |
carloea2
pushed a commit
to carloea2/texera
that referenced
this pull request
Jan 6, 2026
<!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is a work in progress, mark it as a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes. We are following the Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes. Here are some tips for you: 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. 3. If it is a refactoring, could you explain what has been changed? 3. It would be helpful to include a before-and-after comparison using screenshots or GIFs. 4. Please consider writing helpful notes for better and faster reviews. --> This PR adds a feature that enables Texera to efficiently handle tables with vast numbers of columns in the result panel. This PR adds UI features that enable Texera to efficiently handle tables with large numbers of columns in the result viewer and related data preview components. Specifically, this PR introduces: 1. Horizontal Column Pagination 1. "Next Columns" and "Previous Columns" buttons have been added. 2. Columns are now loaded in column windows (configurable size, default 25). 3. Prevents UI freezing or overflow when dealing with tables containing hundreds or thousands of columns. 2. Column Search Bar 1. A new search box allows users to filter or jump directly to column names. 2. When a column is found, that column window is automatically loaded and highlighted. 3. Useful for wide schemas such as: 1. large scientific datasets 2. logs with hundreds of attributes 3. denormalized tables or wide joins 3. Improvements to rendering performance 1. The frontend now only renders the visible subset of columns. 2. Reduces DOM load and improves React change detection speed. ### Any related issues, documentation, or discussions? <!-- Please use this section to link to other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes apache#1234`, `Resolves apache#1234.` or `Closes apache#1234`. If it is only related, mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion on the mailing list, please add the link. --> Fixes: apache#3825 ### How was this PR tested? <!-- If tests were added, say so here. Or mention that if the PR is tested with existing test cases. Please include/update test cases that check the changes thoroughly, including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> 1. Ran a couple of CSV scan operators that produced a wide output table 2. Clicked through column windows in both directions 3. Using search to jump to: - first column - random middle column - last column ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> No ### New Layout: <img width="1905" height="733" alt="image" src="https://github.com/user-attachments/assets/18d14c2d-c134-422f-a5d1-2c826cf3a8e9" /> --------- Co-authored-by: Chen Li <chenli@gmail.com> Co-authored-by: Chris <143021053+kunwp1@users.noreply.github.com> Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR adds a feature that enables Texera to efficiently handle tables with vast numbers of columns in the result panel.
This PR adds UI features that enable Texera to efficiently handle tables with large numbers of columns in the result viewer and related data preview components.
Specifically, this PR introduces:
Any related issues, documentation, or discussions?
Fixes: #3825
How was this PR tested?
Was this PR authored or co-authored using generative AI tooling?
No
New Layout: