Skip to content

Conversation

@ayushtkn
Copy link
Member

@ayushtkn ayushtkn commented Jul 3, 2023

SS:
image
Jstack:
image

@abstractdog
Copy link
Contributor

thanks for the initial patch @ayushtkn! can you take care of the same in the DAGAppMaster too?

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

Change-Id: I8d8b13c03a76a61c053b851743c1d2426e2fdd7b
@tez-yetus

This comment was marked as outdated.

ayushtkn added 2 commits July 4, 2023 00:40
Change-Id: I0353a0dc983a5c02b7bf183d1d5541f15af388dd
Change-Id: Ib0167ef6b52faebc02876ab895f69d8c592a0aca
@tez-yetus

This comment was marked as outdated.

Change-Id: I3d484a6dcadd8f8b880cceb12cae48e22b2580a7
@tez-yetus

This comment was marked as outdated.

@abstractdog
Copy link
Contributor

thanks @ayushtkn, left some minor comments, this is quite close!
can you please try this on a cluster (e.g. with Hive on Tez) to see how it's working in production? we can discuss the details offline

ayushtkn added 3 commits July 5, 2023 18:00
Change-Id: Ie16c5b180d4b19fef43144f48c279e7382965476
Change-Id: I2be6bf61b3925f61a68891d722a830b988f77263
Change-Id: I9d88c928f6591f5590f4bbe601364b8eddf5d8b4
@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

Change-Id: I33993adb8ebd811dae1b3e3eed3d75641fae2956
@tez-yetus

This comment was marked as outdated.

Change-Id: I4ab43d923511668c8e51e8a571bda153b6ccf102
Change-Id: If88667b9e978b648c8d3e85535feeb24201d9879
@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

Change-Id: I0fdeea8971edce4ff2886c757a05306438b96893
@tez-yetus

This comment was marked as outdated.

Change-Id: I4bf6b2c82f6d1455f5f816a07dbcfcd80b603652
@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 45s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 5m 43s Maven dependency ordering for branch
+1 💚 mvninstall 8m 22s master passed
+1 💚 compile 2m 26s master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 compile 2m 8s master passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚 checkstyle 2m 4s master passed
+1 💚 javadoc 1m 54s master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 javadoc 1m 40s master passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+0 🆗 spotbugs 0m 47s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 4m 17s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 1m 26s the patch passed
+1 💚 compile 1m 36s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 javac 1m 36s the patch passed
+1 💚 compile 1m 21s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚 javac 1m 21s the patch passed
+1 💚 checkstyle 0m 12s The patch passed checkstyle in tez-api
+1 💚 checkstyle 0m 9s tez-runtime-internals: The patch generated 0 new + 7 unchanged - 1 fixed = 7 total (was 8)
+1 💚 checkstyle 0m 21s The patch passed checkstyle in tez-dag
+1 💚 checkstyle 0m 12s The patch passed checkstyle in tez-tests
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 54s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 javadoc 0m 53s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚 findbugs 3m 44s the patch passed
_ Other Tests _
+1 💚 unit 2m 16s tez-api in the patch passed.
+1 💚 unit 0m 37s tez-runtime-internals in the patch passed.
+1 💚 unit 4m 56s tez-dag in the patch passed.
+1 💚 unit 39m 3s tez-tests in the patch passed.
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
89m 56s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-299/14/artifact/out/Dockerfile
GITHUB PR #299
JIRA Issue TEZ-4344
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 9af5727e3a09 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 5038075
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-299/14/testReport/
Max. process+thread count 1194 (vs. ulimit of 5500)
modules C: tez-api tez-runtime-internals tez-dag tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-299/14/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog abstractdog self-requested a review July 18, 2023 06:07
@abstractdog abstractdog merged commit a9c5365 into apache:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants