-
Notifications
You must be signed in to change notification settings - Fork 4.1k
THRIFT-5910: Add UUID support in Ruby #3254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Please look at my findings here #3144 to ensure that when the ruby code (your implementation) sends a UUID to the .NET client/server that the values match on the other side. Not an echo test since that only ensures that the client and server has the same understanding, this must specifically be one implementation sending it and the other implementation correctly extracting it There still is no unit tests to confirm this but it would be great if you can do a manual check to ensure that it corresponds to ensure there is a common understanding of the underlying data layout. |
|
I did a full cross-test suite verification with C++, Java, Rust, and Go. Will review your findings as well Edit: I see what you mean, will check what needs to be updated on Ruby cross-tests side. Thank you! Edit2: And you were right: Great finding, thank you! |
|
Unfortunately it is a manual test, run the test and manually check the output of the client and server. And assume the .net implementation is correct |
|
Found another inconsistency while testing constants THRIFT-5911: produces GEN_UUID = %q"00000000-4444-CCCC-ffff-0123456789ab"
GEN_GUID = %q"00112233-4455-6677-8899-aaBBccDDeeFF"
MY_UUID = %q"00000000-4444-CCCC-ffff-0123456789ab"
MY_GUID = %q"{00112233-4455-6677-8899-aaBBccDDeeFF}"Seems like a bit of an issue with the compiler. |
5307ff5 to
5a2cfda
Compare
5a2cfda to
f464d93
Compare
f464d93 to
c04c0d0
Compare
This has been addressed in #3256 |
Currently in draft state until CI fixes are merged in my other pull requests.
This PR adds UUID support to Ruby. The UUID is stored as a string, as this is a common format returned by
SecureRandom.uuidin Ruby. This adds a little bit overhead on writing, as the format of the UUID is verified there.[skip ci]anywhere in the commit message to free up build resources.