TINKERPOP-3136 Removed deprecated/redundant Gremlin testing #3298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenhuuu
reviewed
Jan 26, 2026
|
|
||
| if (scenario.Tags.Any(t => t.Name == "@StepWrite")) | ||
| { | ||
| failedSteps.Add(scenario.Steps.First(), new IgnoreException(IgnoreReason.TreeStepNotSupported)); |
Contributor
There was a problem hiding this comment.
Nit: Should probably make a new IgnoreReason instead of using TreeStepNotSupported for these write tests.
Cole-Greer
reviewed
Jan 27, 2026
| * Added boolean parsing step `asBool()`. | ||
| * Added validation to `valueMap()`, `propertyMap()`, `groupCount()`, `sack()`, `dedup()`, `sample()`, and `aggregate()` to prevent the invalid usage of multiple `by()` modulators. | ||
| * Deprecated `ProcessLimitedStandardSuite` and `ProcessLimitedComputerSuite` in favor of `ProcessEmbeddedStandardSuite` and `ProcessEmbeddedComputerSuite` respectively. | ||
| * Deprecated `ProcessEmbeddedStandardSuite` and `ProcessEmbeddedComputerSuite` in favor of `ProcessEmbeddedStandardSuite` and `ProcessEmbeddedComputerSuite` respectively. |
Contributor
There was a problem hiding this comment.
I don't think we should edit the 4.0.0-beta.1 changelog, this line was accurate for that release.
Contributor
Author
There was a problem hiding this comment.
bad find/replace i guess. thanks for noticing that.
spmallette
force-pushed
the
TINKERPOP-3136
branch
from
4481264 to
d4c4e6a
Compare
Added gherkin testing for write() for cases that could support it so that the Gremlin language had full coverage there. Updated docs to reflect the requirement for Gherkin going forward.
spmallette
force-pushed
the
TINKERPOP-3136
branch
from
d4c4e6a to
8f1c279
Compare
Contributor
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3136
Added gherkin testing for write() for cases that could support it so that the Gremlin language had full coverage there. Updated docs to reflect the requirement for Gherkin going forward.
VOTE +1