Skip to content

WIP on Concurrency work #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rzo1 merged 31 commits into from
Jan 30, 2024
Merged

WIP on Concurrency work #1103

rzo1 merged 31 commits into from
Jan 30, 2024

Conversation

@rzo1
Copy link
Contributor

@rzo1 rzo1 commented Jan 18, 2024

This is a new PR as I moved the code to the TomEE repo in order to allow people to fork and directly PR this branch. FYI @jgallimore

jgallimore and others added 15 commits February 20, 2023 22:38
@rzo1 rzo1 mentioned this pull request Jan 18, 2024
Closed
@tandraschko @rzo1
- removed deprecated EL method override
1932390 
- fallback to a default ContextService in ManagedScheduledExecutorServiceImpl
- removed unused var in CUTask
- removed not-existing jetty dependency
@tandraschko
Copy link
Member

tandraschko commented Jan 18, 2024

@jgallimore there are currently 2 tests failing, could you check it?

https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/65/

CustomInjectionTest defines a ManagedExecutorService
.property("concurrent/es", "new://Resource?type=ManagedExecutorService")

and tests the injection, which is null:

    @Resource(name = "concurrent/es")
    private ManagedExecutorService es;

@rzo1 @jeanouii @jgallimore
TOMEE-4159 - Concurrency TCK (#1084)
049e9ad 
* TOMEE-4164 JSON-B TCK

* TOMEE-4165 JSON-P TCK

* TOMEE-4165 Add pluggability tests

* Adding concurrency TCK

* Update API version

* Merge latest changes from main

* Cleanup from previous merges, only focus on concurrency tck

* Cleanup from previous merges, only focus on concurrency tck

* Fix artifact id's but much work is needed here

* Fix versions

* Align version with TCK

* Get some changes from 4931d63

* Some additional changes from the other branch

* License fixes for xml files

* Adds FIXME for impl

* Adds concurrency tck in a separate profile

---------

Co-authored-by: Jean-Louis Monteiro <jlmonteiro@tomitribe.com>
Co-authored-by: Jonathan Gallimore <jon@jrg.me.uk>
@rzo1
Copy link
Contributor Author

rzo1 commented Jan 25, 2024

The only failing test related to this change is ManagedExecutorServiceGetPrincipalInTaskTest. I guess, that wiring up the security service with async/managed executors isn't complete. FYI @jgallimore

@rzo1
Copy link
Contributor Author

rzo1 commented Jan 26, 2024

Full build looks good now. Only the usual toggles are failing: https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/69/#showFailuresLink

@tandraschko
Copy link
Member

tandraschko commented Jan 26, 2024

Yeah 🙏 so lets merge?

@rzo1
Copy link
Contributor Author

rzo1 commented Jan 30, 2024

Yeah 🙏 so lets merge?

Yup. Think we are good to go now (at least with this first impl), full build is ok and we can take care of the new tck later.

@rzo1 rzo1 merged commit 3bfb14b into main Jan 30, 2024
@rzo1 rzo1 deleted the concurrency-work branch January 30, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rzo1 @tandraschko @jgallimore