TOMEE-4443 update comparison page #1741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jungm
requested changes
Jan 11, 2025
Member
jungm
left a comment
jungm
left a comment
There was a problem hiding this comment.
just a few minor changes needed
github doesn't let me annotate it because it is not part of the diff (?), but there is also a title that hasn't been updated:
== [[implementations]] Implementations of Jakarta EE and MicroProfile features in TomEE 9.x
docs/comparison.adoc
Outdated
| |https://jakarta.ee/specifications/xml-binding/3.0/[Jakarta XML Binding^] (JAXB) 3.0||{y}|{y}|{y}|{y} | ||
| // MICRO PROFILE | ||
| |https://download.eclipse.org/microprofile/microprofile-5.0/microprofile-spec-5.0.html[MicroProfile specifications^] 5.0|||{y}|{y}|{y} | ||
| |https://download.eclipse.org/microprofile/microprofile-6.0/microprofile-spec-6.0.html[MicroProfile specifications^] 5.0|||{y}|{y}|{y} |
Member
There was a problem hiding this comment.
Text is not updated, still says MP 5
docs/comparison.adoc
Outdated
| |Jakarta Persistence (JPA)|https://hibernate.org/orm/[Hibernate ORM^] {y} 6.6.x | ||
| |Jakarta MVC| | ||
| https://eclipse-ee4j.github.io/krazo/[Eclipse Krazo^] {y} 2.0.x + | ||
| https://eclipse-ee4j.github.io/krazo/[Eclipse Krazo^] {y} 3.0.x + |
Member
There was a problem hiding this comment.
Krazo 3.0.0 dropped CXF support (eclipse-ee4j/krazo@96a839e), we should probably not mention it anymore
Contributor
Author
|
Thanks for the review @jungm ! I think I've managed to resolve those items and hopefully this is now ready to merge. |
rzo1
approved these changes
Jan 16, 2025
jungm
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.