When a ds request is immediately fulfilled, the DS is not updating in TP

[mitchell852]

I'm submitting a ...

• bug report
• new feature / enhancement request
• improvement request (usability, performance, tech debt, etc.)
• other

Traffic Control components affected ...

• CDN in a Box
• Documentation
• Grove
• Traffic Control Client
• Traffic Monitor
• Traffic Ops
• Traffic Ops ORT
• Traffic Portal
• Traffic Router
• Traffic Stats
• Traffic Vault
• unknown

Current behavior:

When dsRequests are turned on in traffic_portal_properties.json and a delivery service is updated, a delivery service request is created. However, if the user has the overrideRole (also defined in traffic_portal_properties.json), they can fulfill the delivery service request immediately and immediately apply the delivery service changes.

Fulfilling the delivery service request immediately will:

1. update the underlying delivery service and
2. fetch the updated delivery service to recreate the ds form

2 should only happen after 1 is done. That is not happening and therefore 2 is fetching the old ds.

Expected / new behavior:

2 should only happen after 1 is done. ^^ see above.

Minimal reproduction of the problem with instructions:

• Turn dsRequests on in traffic_portal_properties.json
• Set the overrideRole in traffic_portal_properties.json (i.e. admin)
• Login to TP as a user with the overrideRole
• Update an existing delivery service. For example, change the routing name.
• Fulfill the ds request immediately
• Notice that the routing name did not change in the Delivery Service URL(s) section
• Refresh the browser. Notice that the routing name has now changed in the Delivery Service URL(s) section.