This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Add TM monitoring.json validity check for safety#3526
Merged
mitchell852 merged 3 commits intoapache:masterfrom Apr 30, 2019
Merged
Add TM monitoring.json validity check for safety#3526mitchell852 merged 3 commits intoapache:masterfrom
mitchell852 merged 3 commits intoapache:masterfrom
Conversation
rob05c
added
new feature
rob05c
force-pushed
the
tm-add-monitoring-json-safety-check
branch
from
98097e4 to
904bc58
Compare
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
Because monitoring.json DSes are currently empty, due to a TO bug. See apache#3528
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
ezelkow1
approved these changes
Apr 29, 2019
Member
Author
|
retest this please |
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Includes unit tests. No documentation, no changelog, no interface change.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
go test. Run the Monitor, make sure it works as expected. Set the Traffic Ops databasesnapshottablemonitoringcolumn to{}, verify an error is logged, and TM continues to function. Restart Monitor, verify an error is logged and Monitor does not startup (you may need to delete the backup tmconfig.backup, to prevent it from starting with the backup when the TO monitoring.json is bad).The following criteria are ALL met by this PR