Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TP: fixes table headers in cdn snapshot view#3952

Merged
ocket8888 merged 4 commits intoapache:masterfrom
mitchell852:issue-3863-snapshot-header
Oct 18, 2019
Merged

TP: fixes table headers in cdn snapshot view#3952
ocket8888 merged 4 commits intoapache:masterfrom
mitchell852:issue-3863-snapshot-header

Conversation

@mitchell852
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 commented Oct 2, 2019

What does this PR (Pull Request) do?

On the CDN snapshot view page, this change adjusts column headers when tab is selected and data table is visible to ensure the table header widths are correct.

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  1. Navigate to https://localhost:8442/#!/cdns/1/config/changes
  2. click on the tabs and ensure the column headers of each table are the correct width

Verifying the widths of column headers depends on the user's window size so can't think of a way to test this programatically.
Documentation is already correct.
No need for a change log entry

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1 labels Oct 2, 2019
@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Oct 3, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4385/

Comment thread traffic_portal/app/src/modules/private/cdns/config/ConfigController.js Outdated
Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table headers are still incorrect when the tab is first loaded; if you click on a different tab and then the one you were just on again, then it's fixed. But again, still wrong on initial load.

@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Oct 4, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4399/

@mitchell852
Copy link
Copy Markdown
Member Author

ers are still incorrect when the tab is first loaded; if you click on a different tab and then the one you were just on again, then it's fixed. But again, still wrong on initial load.

try now. not very proud of this hack but seems to work for me in chrome and firefox.

@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Oct 8, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4415/

@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Oct 8, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4416/

@ocket8888
Copy link
Copy Markdown
Contributor

I don't generally like using scripts to fix styling; styling should fix styling. What's wrong with:

div.dataTables_scrollHeadInner {
    width: 100% !important;
}

?

@mitchell852
Copy link
Copy Markdown
Member Author

I don't generally like using scripts to fix styling; styling should fix styling. What's wrong with:

div.dataTables_scrollHeadInner {
    width: 100% !important;
}

?

I can give it a shot. I was under the impression this bug was due to the datatables not being visible because they are hidden inside of tabs.

@mitchell852
Copy link
Copy Markdown
Member Author

i definitely like that solution better but the column headers are not quite right

image

@ocket8888
Copy link
Copy Markdown
Contributor

hm... I guess it's setting the widths explicitly, but just doing it wrong and never updating it. jQuery libraries..... Anyway, the little hiccup the page does when using a script to fix it is annoying, but if the CSS can't work properly I guess we've got no choice but to live with it until we eventually switch to Angular 7.

Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass, fixes the issue, no _.js dependency 👍

@ocket8888 ocket8888 merged commit 6d86f92 into apache:master Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TP: table header in CDN Snapshot diff page is screwed up

3 participants