This repository was archived by the owner on Nov 24, 2025. It is now read-only.
TR: Send reason-phrase for HTTP API responses#4096
Closed
zrhoffman wants to merge 1 commit intoapache:masterfrom
Closed
TR: Send reason-phrase for HTTP API responses#4096zrhoffman wants to merge 1 commit intoapache:masterfrom
zrhoffman wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Can one of the admins verify this patch? |
5 tasks
Member
Author
|
We're using Tomcat 9, which removes reason-phrases altogether, so #4096 is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Reason-phrases are sent for routing over HTTP, routing over HTTPS, and the API over HTTPS, but not for the API over HTTP. This PR adds reason-phrases for the API over HTTP.
As @ocket8888 noted in #4074, Pygments needs reason-phrases for HTTP responses (of any HTTP version).
This PR does not include tests because
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
In the CDN-in-a-box directory,
docker-compose exec trafficrouter curl -I http://trafficrouter:3333/crs/statsIf this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information