Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TR: Send reason-phrase for HTTP API responses#4096

Closed
zrhoffman wants to merge 1 commit intoapache:masterfrom
zrhoffman:api_http_reason-phrase
Closed

TR: Send reason-phrase for HTTP API responses#4096
zrhoffman wants to merge 1 commit intoapache:masterfrom
zrhoffman:api_http_reason-phrase

Conversation

@zrhoffman
Copy link
Copy Markdown
Member

@zrhoffman zrhoffman commented Nov 7, 2019

What does this PR (Pull Request) do?

Reason-phrases are sent for routing over HTTP, routing over HTTPS, and the API over HTTPS, but not for the API over HTTP. This PR adds reason-phrases for the API over HTTP.

As @ocket8888 noted in #4074, Pygments needs reason-phrases for HTTP responses (of any HTTP version).

  • This PR is not related to any Issue

This PR does not include tests because

  • The only component that depends on reason-phrases as far as I know is the documentation.
  • HTTP/2 responses have no reason-phrases.
  • If documentation ever stops failing to build due to no reason-phrase in a documented HTTP response, there is no reason to send one anymore, so building the documentation is a de facto test.

Which Traffic Control components are affected by this PR?

  • Traffic Router

What is the best way to verify this PR?

In the CDN-in-a-box directory,

docker-compose exec trafficrouter curl -I http://trafficrouter:3333/crs/stats

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • I have explained why tests are unnecessary
  • This PR does not need documentation because expected behavior does not change
  • This PR does not include an update to CHANGELOG.md, such an update is not necessary
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@asf-ci
Copy link
Copy Markdown
Contributor

asf-ci commented Nov 7, 2019

Can one of the admins verify this patch?

@ocket8888 ocket8888 added improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Router related to Traffic Router labels Nov 8, 2019
@zrhoffman
Copy link
Copy Markdown
Member Author

zrhoffman commented Nov 4, 2022

We're using Tomcat 9, which removes reason-phrases altogether, so #4096 is no longer needed.

@zrhoffman zrhoffman closed this Nov 4, 2022
@zrhoffman zrhoffman deleted the api_http_reason-phrase branch February 7, 2023 22:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Router related to Traffic Router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants