This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Ciab atstccfg#4671
Merged
mattjackson220 merged 49 commits intoapache:masterfrom Jun 24, 2020
Merged
Conversation
ocket8888
added
new feature
ocket8888
force-pushed
the
ciab-atstccfg
branch
from
60aa41c to
dc1860a
Compare
zrhoffman
suggested changes
Apr 30, 2020
zrhoffman
reviewed
Apr 30, 2020
Member
|
There is a merge conflict in |
…nfig fetch to atstccfg
zrhoffman
suggested changes
Jun 24, 2020
zrhoffman
approved these changes
Jun 24, 2020
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
HTTP and HTTPS delivery services return successful response codes, CDN-in-a-Box readiness container exits successfully.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR depends on #2776 .
Adds
atstccfgto CDN-in-a-Box, allowing for a better representation of a true ATC system, and eliminating the dependency on my personal PyPI hosting of an old version of the TO Python client.Also fixes the
atstccfgdocs, since the current behavior does not match what is documented.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
The old
testdirectory for ORT.py had a single test in it for setting API versions on configuration file objects returned by the old 1.x "meta config" route. Since that's now handled by ATSTCCFG, it's been removed. Instead, there's an executabledoctest-runner.pyfile at the top of the ORT.py package that runs the doctests which already existed to some degree. In fact, they helped me find some bugs when I was building this. So just run that file to check for errors in the examples in docstrings.But to be really sure, you'll need to start up CDN-in-a-Box and make sure that the
BADASSrun doesn't fail (which means ORT.py performed every operation it needs to perform and did it successfully). If it does fail, you'll see "Failed" echoed in the edge/mid cache servers' logs. The containers don't crash though, so that the problem can be debugged - so be careful not to assume that. If everything goes well, the "clocks" in TP should be cleared for edge and mid, and both should be marked available by TM.If this is a bug fix, what versions of Traffic Control are affected?
This technically includes a docs bug fix, which is present in:
The following criteria are ALL met by this PR