This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Cachegroups API updates for Topologies#4695
Merged
ocket8888 merged 3 commits intoapache:masterfrom May 18, 2020
Merged
Conversation
- for GET /cachegroups add support for a topology query param for returning all cachegroups that are used in a given topology - for DELETE /cachegroups/:id return an informative error message if trying to delete a cachegroup that is currently used by a topology
rawlinp
added
new feature
zrhoffman
suggested changes
May 18, 2020
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
This looks good. Docs build, code is formatted correctly, and API tests pass. I left a few suggestions, but they are all optional.
zrhoffman
approved these changes
May 18, 2020
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
API tests still pass, code is still formatted correctly. Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Add support for
topologyquery param onGET /api/3.0/cachegroupsAPI. Return a useful error message when attempting to delete a cachegroup that is used in a Topology.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the unit tests, verify they pass. Run the TO API tests, verify they pass. Attempt to delete a cachegroup that is assigned to a topology, verify that a useful error message is returned.
The following criteria are ALL met by this PR