This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Prohibit assigning topology-based delivery services to caches#4702
Merged
dneuman64 merged 2 commits intoapache:masterfrom Jun 1, 2020
Merged
Prohibit assigning topology-based delivery services to caches#4702dneuman64 merged 2 commits intoapache:masterfrom
dneuman64 merged 2 commits intoapache:masterfrom
Conversation
20f3120 to
63b031f
Compare
7 tasks
zrhoffman
suggested changes
May 29, 2020
Member
zrhoffman
left a comment
There was a problem hiding this comment.
API tests pass, unit tests pass, code is formatted correctly, and manual testing confirms you can't assign a topology-based delivery service to an edge cache bug you can assign it an origin.
Just a couple of comments about error messages. Besides that, this looks good.
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Update the following endpoints to prevent assigning caches to delivery services that have a topology assigned:
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the unit tests. Run the TO API tests (negative tests were added for all 4 routes). Verify they all pass.
The following criteria are ALL met by this PR