Snapshot interfaces

[ocket8888]

What does this PR (Pull Request) do?

• This PR fixes Update /cdns/{{name}}/snapshot to use data from new interfaces tables #4616 and fixes Update /cdns/{{name}}/snapshot/new to use data from the new interfaces tables #4617

Updates CDN Snapshot generation to account for multiple server interfaces.

Which Traffic Control components are affected by this PR?

• Traffic Ops

What is the best way to verify this PR?

Run the unit and API tests, run CDN-in-a-Box and verify the snapshot is successful.

The following criteria are ALL met by this PR

• No interface change, so existing tests should be sufficient
• No interface change, so no documentation necessary
• This PR includes an update to CHANGELOG.md
• This PR includes any and all required license headers
• This PR does not include a database migration
• This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

[shamrickus]

> go test ./...
--- FAIL: TestGetAllServers (0.00s)
    servers_test.go:208: getAllServers expected: nil error, actual: Error querying servers: Query 'SELECT s.id, s.host_name, cg.name as cachegroup, concat(s.host_name, '.', s.domain_name) AS fqdn, s.xmpp_id AS hashid, s.https_port, s.tcp_port, p.name AS profile_name, cast(p.routing_disabled AS int), st.name AS status, t.name AS type FROM server AS s INNER JOIN cachegroup AS cg ON cg.id = s.cachegroup INNER JOIN type AS t on t.id = s.type INNER JOIN profile AS p ON p.id = s.profile INNER JOIN status AS st ON st.id = s.status WHERE cdn_id = (SELECT id FROM cdn WHERE name = $1) AND (st.name = 'REPORTED' OR st.name = 'ONLINE' OR st.name = 'ADMIN_DOWN')', does not match regex [select]
--- FAIL: TestGetAllServersNonService (0.00s)
    servers_test.go:254: getAllServers expected: nil error, actual: Error querying servers: Query 'SELECT s.id, s.host_name, cg.name as cachegroup, concat(s.host_name, '.', s.domain_name) AS fqdn, s.xmpp_id AS hashid, s.https_port, s.tcp_port, p.name AS profile_name, cast(p.routing_disabled AS int), st.name AS status, t.name AS type FROM server AS s INNER JOIN cachegroup AS cg ON cg.id = s.cachegroup INNER JOIN type AS t on t.id = s.type INNER JOIN profile AS p ON p.id = s.profile INNER JOIN status AS st ON st.id = s.status WHERE cdn_id = (SELECT id FROM cdn WHERE name = $1) AND (st.name = 'REPORTED' OR st.name = 'ONLINE' OR st.name = 'ADMIN_DOWN')', does not match regex [select]
FAIL
FAIL	github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/crconfig	0.010s
FAIL

[rawlinp]

Unit test job failed with this:

unit_1  | === RUN   TestGetMidServers
unit_1  |     TestGetMidServers: servers_test.go:475: getMidServers expected: len(mid) == 1, actual: 0
unit_1  | --- FAIL: TestGetMidServers (0.00s)

[ocket8888]

I can't reproduce that failure. All unit tests are passing for me.

[rawlinp]

Ok, I'll pull this down and test when the CI completes again.

[shamrickus]

The unit tests pass for me as well.

[rawlinp]

TO API tests pass, unit tests pass, taking a snapshot appears to be good (only saw ipv6 addresses going from uppercase to lowercase which seems to be expected now).