This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Supporting routing for topology-based delivery services#4724
Merged
rawlinp merged 30 commits intoapache:masterfrom Jun 24, 2020
Merged
Supporting routing for topology-based delivery services#4724rawlinp merged 30 commits intoapache:masterfrom
rawlinp merged 30 commits intoapache:masterfrom
Conversation
rawlinp
added
documentation
rawlinp
suggested changes
Jun 4, 2020
rawlinp
suggested changes
Jun 8, 2020
zrhoffman
force-pushed
the
topologies_routing
branch
from
e88e73a to
341d1c6
Compare
Member
Author
required capabilities
zrhoffman
force-pushed
the
topologies_routing
branch
from
a3d700b to
a5cb269
Compare
rawlinp
reviewed
Jun 23, 2020
rawlinp
suggested changes
Jun 23, 2020
Contributor
rawlinp
left a comment
rawlinp
left a comment
There was a problem hiding this comment.
DNS-based and HTTP-based routing now both appear to be functional for topology-based delivery services, but the tests are failing with NPEs:
Tests in error:
ConfigHandlerTest.itParsesTheTopologiesConfig:288 » NullPointer
DeliveryServiceTest.itAddsRequiredCapabilities:86 » NullPointer
DeliveryServiceTest.itConfiguresRequestHeadersFromJSON:77 » NullPointer
DeliveryServiceTest.itExtractsQueryParams:68 » NullPointer
DeliveryServiceTest.itHandlesDuplicatesInConsistentHashQueryParams:55 » NullPointer
DeliveryServiceTest.itHandlesLackOfConsistentHashQueryParamsInJSON:46 » NullPointer
DeliveryServiceTest.itHandlesLackOfRequestHeaderNamesInJSON:38 » NullPointer
ConsistentHasherTest.itHashesQueryParams:216 » NullPointer
DeliveryServiceHTTPRoutingMissesTest.before:52 » NullPointer
DeliveryServiceHTTPRoutingMissesTest.before:52 » NullPointer
DeliveryServiceHTTPRoutingMissesTest.before:52 » NullPointer
Tests run: 211, Failures: 0, Errors: 11, Skipped: 23
a797a3a to
bedb52d
Compare
zrhoffman
force-pushed
the
topologies_routing
branch
from
bedb52d to
68c2181
Compare
Member
Author
|
Tests pass now in 68c2181. |
Contributor
|
That appears to have fixed ConfigHandlerTest, but I'm still seeing errors on the other ones: |
Member
Author
|
NullPointer exceptions in ConsistentHasherTest, DeliveryServiceHTTPRoutingMissesTest, and DeliveryServiceTest fixed in e162d16. |
rawlinp
approved these changes
Jun 24, 2020
Contributor
rawlinp
left a comment
rawlinp
left a comment
There was a problem hiding this comment.
Confirmed that TR unit and integration tests are passing now.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bug fix, what versions of Traffic Control are affected?
Not a bug fix.
The following criteria are ALL met by this PR