Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add new header_rewrite fields for topology-based DSes#4807

Merged
ocket8888 merged 6 commits intoapache:masterfrom
rawlinp:topologies-header-rewrite
Jun 23, 2020
Merged

Add new header_rewrite fields for topology-based DSes#4807
ocket8888 merged 6 commits intoapache:masterfrom
rawlinp:topologies-header-rewrite

Conversation

@rawlinp
Copy link
Copy Markdown
Contributor

@rawlinp rawlinp commented Jun 19, 2020

What does this PR (Pull Request) do?

Add the new firstHeaderRewrite, innerHeaderRewrite, and lastHeaderRewrite fields to delivery services. These fields can only be used when the delivery service is assigned to a topology and are mutually exclusive with edgeHeaderRewrite and midHeaderRewrite, which can not be used if the delivery service is assigned to a topology.

NOTE: this PR intentionally does not create and link "location" parameters for these new header rewrite fields, because this extra information is unnecessary for client-side config generation via atstccfg and would just lead to a load of unnecessary complexity. Additionally, I think we should get rid of "location" parameters altogether, so increasing and perpetuating their usage is not ideal.

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run the unit tests and TO API tests, verify they pass. Build the docs, verify nothing broke. View the rendered documentation changes, make sure they look correct.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@rawlinp rawlinp added new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops labels Jun 19, 2020
@ocket8888
Copy link
Copy Markdown
Contributor

When you say that the new fields are "mutually exclusive" with the old ones, do you mean that only one set can be non-null/empty at a time (and presumably must be the topologies ones if it has an assigned topology and vice-versa), or just that only one set will have any effect at one time?

@rawlinp
Copy link
Copy Markdown
Contributor Author

rawlinp commented Jun 19, 2020

@rawlinp rawlinp marked this pull request as ready for review June 22, 2020 21:52
Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs build without warnings related to this PR, unit tests pass, API tests pass, delivery services work in CDN-in-a-Box as expected. Verified there are no regressions.

@ocket8888 ocket8888 merged commit e9d9a78 into apache:master Jun 23, 2020
@rawlinp rawlinp deleted the topologies-header-rewrite branch June 23, 2020 18:06
@rawlinp rawlinp mentioned this pull request Jun 23, 2020
7 tasks
@mitchell852 mitchell852 added the database relating to setup/installation/structure of the Traffic Ops database label Aug 28, 2020
@zrhoffman zrhoffman added this to the Flexible Topologies milestone Sep 18, 2020
@zrhoffman zrhoffman removed this from the Flexible Topologies milestone Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

database relating to setup/installation/structure of the Traffic Ops database new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants