This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Add new header_rewrite fields for topology-based DSes#4807
Merged
ocket8888 merged 6 commits intoapache:masterfrom Jun 23, 2020
Merged
Add new header_rewrite fields for topology-based DSes#4807ocket8888 merged 6 commits intoapache:masterfrom
ocket8888 merged 6 commits intoapache:masterfrom
Conversation
Contributor
|
When you say that the new fields are "mutually exclusive" with the old ones, do you mean that only one set can be non-null/empty at a time (and presumably must be the topologies ones if it has an assigned topology and vice-versa), or just that only one set will have any effect at one time? |
Contributor
Author
|
I believe this should answer that question: https://github.com/apache/trafficcontrol/pull/4807/files#diff-e35176dda777cf2b75d030e86b396b1aR486 |
zrhoffman
approved these changes
Jun 23, 2020
Member
zrhoffman
left a comment
There was a problem hiding this comment.
Docs build without warnings related to this PR, unit tests pass, API tests pass, delivery services work in CDN-in-a-Box as expected. Verified there are no regressions.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Add the new
firstHeaderRewrite,innerHeaderRewrite, andlastHeaderRewritefields to delivery services. These fields can only be used when the delivery service is assigned to a topology and are mutually exclusive withedgeHeaderRewriteandmidHeaderRewrite, which can not be used if the delivery service is assigned to a topology.NOTE: this PR intentionally does not create and link "location" parameters for these new header rewrite fields, because this extra information is unnecessary for client-side config generation via
atstccfgand would just lead to a load of unnecessary complexity. Additionally, I think we should get rid of "location" parameters altogether, so increasing and perpetuating their usage is not ideal.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the unit tests and TO API tests, verify they pass. Build the docs, verify nothing broke. View the rendered documentation changes, make sure they look correct.
The following criteria are ALL met by this PR