This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Servers service interface fix#4828
Merged
mitchell852 merged 2 commits intoapache:masterfrom Jun 28, 2020
Merged
Conversation
ocket8888
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Due to false positives in the unit tests, the validation for API v3 servers was believed to be working but actually had a couple of holes:
This PR fixes both the false positives and the actual validation.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the tests (which should now work)
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR