This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fixes regression of the ability to add/remove a capability or a delivery service from a server#4859
Merged
ocket8888 merged 1 commit intoapache:masterfrom Jul 13, 2020
Conversation
…val of serverservice.getServer() in favor of serverservice.getServers(id:x)
mitchell852
added
bug
mitchell852
added
the
high impact
mitchell852
commented
Jul 9, 2020
| resolve: { | ||
| server: function() { | ||
| return server; | ||
| return $scope.server; |
Member
Author
There was a problem hiding this comment.
this one actually fixes the ds/server assignment bug. the rest i just did for some reason :)
ocket8888
approved these changes
Jul 13, 2020
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
Changes look good, confirmed that capabilities and DSes can be given to a server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR