Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Consider Topologies parentage when queueing or checking server updates#4901

Merged
rob05c merged 24 commits intoapache:masterfrom
zrhoffman:topologies_server_updates
Aug 3, 2020
Merged

Consider Topologies parentage when queueing or checking server updates#4901
rob05c merged 24 commits intoapache:masterfrom
zrhoffman:topologies_server_updates

Conversation

@zrhoffman
Copy link
Copy Markdown
Member

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Control Client - Go
  • Traffic Ops

What is the best way to verify this PR?

Run the API tests

docker-compose -f docker-compose.yml up --build --force-recreate -d
docker-compose -f docker-compose.yml -f docker-compose.traffic-ops-test.yml up --build --force-recreate integration

The following criteria are ALL met by this PR

  • This PR includes tests
  • This PR includes documentation
  • This PR includes an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops new feature A new feature, capability or behavior labels Jul 22, 2020
Comment thread traffic_ops/traffic_ops_golang/routing/routes.go Outdated
Copy link
Copy Markdown
Member

@rob05c rob05c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Code generally looks good, mostly minor things. I'm only requesting changes for the log.Error panics, and if you could answer the questions about EDGE? (It might be ok, I'm just not sure, I'll take your word for it)

Haven't run it yet, I'll try to do that shortly

Comment thread traffic_ops/traffic_ops_golang/server/servers_update_status.go
Comment thread traffic_ops/traffic_ops_golang/server/servers_update_status.go Outdated
Comment thread traffic_ops/traffic_ops_golang/server/servers_update_status.go Outdated
Comment thread traffic_ops/traffic_ops_golang/server/servers_update_status.go Outdated
Comment thread traffic_ops/traffic_ops_golang/server/servers_update_status.go Outdated
Comment thread traffic_ops/traffic_ops_golang/server/servers_update_status.go Outdated
Comment thread traffic_ops/traffic_ops_golang/server/servers_update_status.go Outdated
Comment thread traffic_ops/traffic_ops_golang/server/servers_update_status.go
Comment thread traffic_ops/traffic_ops_golang/server/servers_update_status.go
Comment thread traffic_ops/traffic_ops_golang/server/servers_update_status.go Outdated
@zrhoffman zrhoffman requested a review from rob05c July 30, 2020 17:32
@zrhoffman
Copy link
Copy Markdown
Member Author

retest this please

Copy link
Copy Markdown
Member

@rob05c rob05c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Code looks good, unit tests pass, TO API tests pass. Manually tested, setting status on a mid queues edges in its topology, /update_status returns parent_pending when a parent in the topology is queued even if no traditional parents are.

@rob05c
Copy link
Copy Markdown
Member

rob05c commented Aug 3, 2020

retest this please

@rob05c rob05c merged commit a48fab6 into apache:master Aug 3, 2020
@rob05c rob05c mentioned this pull request Aug 4, 2020
7 tasks
@zrhoffman zrhoffman deleted the topologies_server_updates branch August 6, 2020 18:33
@zrhoffman zrhoffman added this to the Flexible Topologies milestone Sep 18, 2020
@zrhoffman zrhoffman removed this from the Flexible Topologies milestone Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify server status endpoints to take Topology parentage into account

3 participants