This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Consider Topologies parentage when queueing or checking server updates#4901
Merged
rob05c merged 24 commits intoapache:masterfrom Aug 3, 2020
Merged
Consider Topologies parentage when queueing or checking server updates#4901rob05c merged 24 commits intoapache:masterfrom
rob05c merged 24 commits intoapache:masterfrom
Conversation
descendant cachegroups of that server's cachegroup
comments for syntax highlighting
deprecated support for servers/all/update_status for API versions below 3.0
set parent_pending to true
rob05c
reviewed
Jul 24, 2020
rob05c
suggested changes
Jul 24, 2020
Member
rob05c
left a comment
There was a problem hiding this comment.
Looks good! Code generally looks good, mostly minor things. I'm only requesting changes for the log.Error panics, and if you could answer the questions about EDGE? (It might be ok, I'm just not sure, I'll take your word for it)
Haven't run it yet, I'll try to do that shortly
Member
Author
|
retest this please |
GetServerUpdateStatusHandlerV1()
legacy cachegroup parentage simultaneously exist
rob05c
approved these changes
Aug 3, 2020
Member
|
retest this please |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
PUT /api/3.0/servers/{id}/statusGET /api/3.0/servers/{host_name}/update_statusWhich Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the API tests
The following criteria are ALL met by this PR