Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Validating absolute DNS name requirement on Static DNS Entry Type#4934

Merged
mitchell852 merged 18 commits intoapache:masterfrom
rimashah25:bugfix/CDN-10101
Aug 12, 2020
Merged

Validating absolute DNS name requirement on Static DNS Entry Type#4934
mitchell852 merged 18 commits intoapache:masterfrom
rimashah25:bugfix/CDN-10101

Conversation

@rimashah25
Copy link
Copy Markdown
Contributor

@rimashah25 rimashah25 commented Aug 3, 2020

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Portal
  • Traffic Ops

What is the best way to verify this PR?

Manual Testing

  1. Create a HTTP delivery service
  2. Click on More and then add Static DNS entry
  3. Select a Type:CNAME_RECORD and type address without a trailing period. On clicking create, you should see an error stating: address must be a valid DNS entry. Missing a trailing period at the end.
  4. Once you do add a trailing period, you can create a static DNS entry with a successful message.

Automation Testing

  1. Run CIAB
  2. Run Traffic_Portal locally (make sure the Traffic_Ops url point to CIAB traffic ops url)
  3. Ensure protractor and webdriver-manage are installed.
  4. Run webdriver-manager start
  5. Run protractor config.js from traffic_control/traffic_portal/test/end-to-end/ folder
  6. All 73 specs should pass. 73 specs, 0 failures

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests
  • This PR does not include documentation
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Comment thread traffic_portal/app/src/common/service/utils/LocationUtils.js Outdated
@rimashah25 rimashah25 marked this pull request as ready for review August 7, 2020 00:06
@rimashah25 rimashah25 requested a review from mitchell852 August 7, 2020 00:09
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. works well. just some minor comments.

Comment thread traffic_ops/traffic_ops_golang/staticdnsentry/staticdnsentry.go Outdated
Comment thread docs/source/api/v2/staticdnsentries.rst Outdated
Comment thread docs/source/api/v2/staticdnsentries.rst
Comment thread docs/source/api/v3/staticdnsentries.rst Outdated
Comment thread traffic_ops/traffic_ops_golang/staticdnsentry/staticdnsentry.go Outdated
Comment thread traffic_portal/test/end_to_end/deliveryServices/delivery-services-spec.js Outdated
Comment thread traffic_portal/test/end_to_end/deliveryServices/delivery-services-spec.js Outdated
Comment thread traffic_portal/test/end_to_end/deliveryServices/pageData.js Outdated
Comment thread traffic_portal/test/end_to_end/deliveryServices/pageData.js Outdated
@mitchell852
Copy link
Copy Markdown
Member

also, there are 4 types, right?

image

are there any rules for TXT_RECORD? if so, want to add it to your tooltip?

image

@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops improvement The functionality exists but it could be improved in some way. Traffic Portal v1 related to Traffic Portal version 1 labels Aug 7, 2020
Comment thread traffic_ops/traffic_ops_golang/staticdnsentry/staticdnsentry.go Outdated
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple more places to update the rules.

@rimashah25 rimashah25 requested a review from mitchell852 August 11, 2020 17:33
Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML and docs look fine

Copy link
Copy Markdown
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api tests pass, ui tests pass. tested manually. looks good!

@mitchell852 mitchell852 merged commit ccf727f into apache:master Aug 12, 2020
@rimashah25 rimashah25 deleted the bugfix/CDN-10101 branch August 18, 2020 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

improvement The functionality exists but it could be improved in some way. Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate absolute DNS name requirement on StaticDNS CNAME

3 participants