This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Validating absolute DNS name requirement on Static DNS Entry Type#4934
Merged
mitchell852 merged 18 commits intoapache:masterfrom Aug 12, 2020
Merged
Validating absolute DNS name requirement on Static DNS Entry Type#4934mitchell852 merged 18 commits intoapache:masterfrom
mitchell852 merged 18 commits intoapache:masterfrom
Conversation
… in table anf form js to support these test cases
…o bugfix/CDN-10101
mitchell852
reviewed
Aug 3, 2020
…ded to DeliveryServiceUtils.
… to ensure both API calls and TP behave the same.
…o bugfix/CDN-10101
mitchell852
reviewed
Aug 7, 2020
mitchell852
suggested changes
Aug 7, 2020
Member
mitchell852
left a comment
There was a problem hiding this comment.
looks good. works well. just some minor comments.
Member
mitchell852
reviewed
Aug 7, 2020
mitchell852
reviewed
Aug 7, 2020
ocket8888
reviewed
Aug 9, 2020
mitchell852
suggested changes
Aug 11, 2020
Member
mitchell852
left a comment
There was a problem hiding this comment.
a couple more places to update the rules.
ocket8888
approved these changes
Aug 11, 2020
Contributor
ocket8888
left a comment
There was a problem hiding this comment.
HTML and docs look fine
mitchell852
approved these changes
Aug 12, 2020
Member
mitchell852
left a comment
There was a problem hiding this comment.
api tests pass, ui tests pass. tested manually. looks good!
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What does this PR (Pull Request) do?
It fixes a bug in Traffic_Portal's UI and Traffic_Ops API callback.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Manual Testing
address must be a valid DNS entry. Missing a trailing period at the end.Automation Testing
73 specs, 0 failuresIf this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information