This repository was archived by the owner on Nov 24, 2025. It is now read-only.
4.1.x Backport: Add ORT/atstccfg Deterministic Config Generation (#4557)#5040
Merged
rawlinp merged 1 commit intoapache:4.1.xfrom Sep 18, 2020
Merged
Conversation
* Make ORT gen deterministic * Add ORT/atstccfg Line-Comment header Adds a header to the multipart file, with the line comment syntax of the file (if it has one). This lets ORT safely strip line comments with times for diffing. * Remove ORT/atstccfg unnecessary io param Removes TCCfg from GetAllConfigs, making the function Pure, which makes it possible/easier to unit test. * Change ORT/atstccfg magic string to const * Add ORT/atstccfg unit test for determinism (cherry picked from commit d74de45)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ORT gen deterministic
Add ORT/atstccfg Line-Comment header
Adds a header to the multipart file, with the line comment syntax of
the file (if it has one).
This lets ORT safely strip line comments with times for diffing.
Removes TCCfg from GetAllConfigs, making the function Pure, which
makes it possible/easier to unit test.
Change ORT/atstccfg magic string to const
Add ORT/atstccfg unit test for determinism
(cherry picked from commit d74de45)
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information