Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TP: handles error scenario when fulfilling a dsr immediately and ds update fails validation#5193

Merged
rawlinp merged 1 commit intoapache:masterfrom
mitchell852:issue-5188-error-msg-dsr
Oct 26, 2020
Merged

TP: handles error scenario when fulfilling a dsr immediately and ds update fails validation#5193
rawlinp merged 1 commit intoapache:masterfrom
mitchell852:issue-5188-error-msg-dsr

Conversation

@mitchell852
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 commented Oct 26, 2020 •
edited
Loading

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1 labels Oct 26, 2020
rawlinp
rawlinp approved these changes Oct 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@rawlinp rawlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@rawlinp rawlinp merged commit 5940129 into apache:master Oct 26, 2020
@rawlinp rawlinp added this to the 4.1.1 milestone Oct 26, 2020
rawlinp pushed a commit to rawlinp/trafficcontrol that referenced this pull request Oct 26, 2020
@mitchell852 @rawlinp
handles error scenario when fulfilling a dsr immediately and ds updat…
b24e6d2 
…e fails (apache#5193)

(cherry picked from commit 5940129)
@rawlinp rawlinp mentioned this pull request Oct 26, 2020
Merged
rawlinp added a commit that referenced this pull request Oct 26, 2020
@rawlinp @mitchell852
handles error scenario when fulfilling a dsr immediately and ds updat…
1ba5bc6 
…e fails (#5193) (#5194)

(cherry picked from commit 5940129)

Co-authored-by: Jeremy Mitchell <mitchell852@users.noreply.github.com>
@mitchell852 mitchell852 modified the milestones: 4.1.1, 5.0.0, 4.1.0 Oct 26, 2020
@rawlinp rawlinp modified the milestones: 4.1.0, 5.0.0 Oct 26, 2020
ocket8888 pushed a commit to ocket8888/trafficcontrol that referenced this pull request Oct 29, 2020
@mitchell852 @ocket8888
handles error scenario when fulfilling a dsr immediately and ds updat…
03a6944 
…e fails (apache#5193)

(cherry picked from commit 5940129)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rawlinp rawlinp rawlinp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

TP: error message doesn't display properly when fulfilling an invalid DSR immediately

2 participants

@mitchell852 @rawlinp