This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix parent.config generation for MSO with required capabilities#5383
Merged
zrhoffman merged 1 commit intoapache:masterfrom Dec 18, 2020
Merged
Fix parent.config generation for MSO with required capabilities#5383zrhoffman merged 1 commit intoapache:masterfrom
zrhoffman merged 1 commit intoapache:masterfrom
Conversation
Server capabilities do not apply to ORG servers (origins), so don't check for them.
Contributor
|
re-running ciab check |
zrhoffman
approved these changes
Dec 18, 2020
Member
zrhoffman
left a comment
There was a problem hiding this comment.
-
TestMakeParentDotConfigTopologiesMSOWithCapabilitiesandTestMakeParentDotConfigMSOWithCapabilitiesfail without the fixes included inparentdotconfig.go(but pass with fixes included) -
Without the patch:
- A MSO DS whose origin servers do not satisfy its required capabilities yields an empty
parent.config(other than the# DO NOT EDITcomment) for servers in the child cachegroup of the ORG_LOC cachegroup. parent.configis successfully populated if the origin servers do satisfy the DS's required capabilities (by inserting server server capabilities directly into the DB).- This is the case for topology-based and non-topology-based delivery services.
- A MSO DS whose origin servers do not satisfy its required capabilities yields an empty
-
With the patch, the
parent.confighas adest_domain=line that includes the origin servers assigned to the MSO DS, for both topology-based and non-topology-based DSes.
The tests include redundant types, but that is a code style choice and is fine because it is more explicit that way.
ocket8888
pushed a commit
that referenced
this pull request
Dec 18, 2020
Server capabilities do not apply to ORG servers (origins), so don't check for them. (cherry picked from commit df927ac)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Server capabilities do not apply to ORG servers (origins), so don't
check for them.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Create an MSO delivery service (
multiSiteOrigin: true) and a required capability. Assign 2 ORG servers and at least 1 EDGE server to the delivery service. The EDGE server must have the required capability. Make sure at least 1 MID in the CDN also has the required capability. On that MID, run ORT and verify that the line inparent.configfor this delivery service contains the 2 ORG servers.Next, create a topology with your edge -> mid -> origin cachegroups, and assign it to your MSO delivery service. On the same MID as before, run ORT and verify that the line in
parent.configfor this delivery service contains the 2 ORG servers.If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR