Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Topology based DS's + reqd capabilities + ORG servers should show ORG servers, alongwith the other servers when queried for the linked servers#5389

Merged
zrhoffman merged 12 commits intoapache:masterfrom
srijeet0406:CDN-11567
Dec 22, 2020
Merged

Topology based DS's + reqd capabilities + ORG servers should show ORG servers, alongwith the other servers when queried for the linked servers#5389
zrhoffman merged 12 commits intoapache:masterfrom
srijeet0406:CDN-11567

Conversation

@srijeet0406
Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Ops
  • CI tests

What is the best way to verify this PR?

Create a topology based DS with some required capabilities
Assign some ORG servers directly to this DS

Before the fix:
If you query for the servers of this DS using GET /api/3.0/servers?dsId=<YOUR DS ID>, you will only get the edges and mids that are:
1.) In the topology AND
2.) In the same CDN as the DS AND
3.) Have the server capabilities as specified in the DS
You will notice that the ORG servers DO NOT show up in the list.

After the fix:
If you perform the same steps, you will notice that the ORG servers also show up in the result now.

If this is a bug fix, what versions of Traffic Control are affected?

  • master

The following criteria are ALL met by this PR

  • This PR includes tests
  • This PR includes documentation
  • This PR includes an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Comment thread traffic_ops/traffic_ops_golang/server/servers.go Outdated
Comment thread traffic_ops/traffic_ops_golang/server/servers.go Outdated
Comment thread traffic_ops/traffic_ops_golang/server/servers.go Outdated
Comment thread traffic_ops/testing/api/v3/deliveryservices_required_capabilities_test.go Outdated
Comment thread traffic_ops/traffic_ops_golang/server/servers.go Outdated
@zrhoffman zrhoffman merged commit bef0008 into apache:master Dec 22, 2020
@zrhoffman zrhoffman added this to the 5.0.0 milestone Dec 22, 2020
ocket8888 pushed a commit that referenced this pull request Jan 7, 2021
… servers, alongwith the other servers when queried for the linked servers (#5389)

* wip

* wip

* modified query

* adding test

* Adding new test

* adding test in the right file

* refactoring

* changing error msg

* Adding changelog

* code review fixes

* code review fixes

(cherry picked from commit bef0008)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ds topology + required server capabilities + assigned ORG servers not working correctly

2 participants