Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Change t3c-apply log options to -v and -s#5999

Merged
rawlinp merged 1 commit intoapache:masterfrom
rob05c:add-t3c-verbose-log-flags
Jul 8, 2021
Merged

Change t3c-apply log options to -v and -s#5999
rawlinp merged 1 commit intoapache:masterfrom
rob05c:add-t3c-verbose-log-flags

Conversation

@rob05c
Copy link
Copy Markdown
Member

@rob05c rob05c commented Jul 6, 2021

Matching most Linux/UNIX apps, per the ORT rewrite design goal.

Includes tests.
Includes docs.
No changelog, not in a release.

  • This PR is not related to any other Issue

Which Traffic Control components are affected by this PR?

  • Traffic Ops ORT

What is the best way to verify this PR?

Run tests. Run t3c apps with -vv args, verify expected log level is output to stderr.

If this is a bug fix, what versions of Traffic Control are affected?

Not a bug fix.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@rob05c rob05c added new feature A new feature, capability or behavior cache-config Cache config generation labels Jul 6, 2021
@rob05c rob05c force-pushed the add-t3c-verbose-log-flags branch 2 times, most recently from c339b8c to d66a6ae Compare July 7, 2021 22:08
Matching most Linux/UNIX apps, per the ORT rewrite design goal.
@rob05c rob05c force-pushed the add-t3c-verbose-log-flags branch from d66a6ae to bee3adb Compare July 7, 2021 22:57
Copy link
Copy Markdown
Contributor

@traeak traeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, tests of each option runs fine.

@rawlinp rawlinp merged commit def9350 into apache:master Jul 8, 2021
@jhg03a jhg03a mentioned this pull request Jul 30, 2021
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cache-config Cache config generation new feature A new feature, capability or behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants