Support queueing updates by type and profile by srijeet0406 · Pull Request #6014 · apache/trafficcontrol

srijeet0406 · 2021-07-12T20:12:45Z

What does this PR (Pull Request) do?

This PR fixes Support Queuing Updates by Server Type #4982 and fixes Add the ability to queue updates for all servers of a given profile #3669

Which Traffic Control components are affected by this PR?

Documentation
Traffic Ops
CI tests

What is the best way to verify this PR?

Make sure all the API/ unit tests pass.
Manual testing:
Run TO and TP locally.
Go to TP and click on a TYPE that is used in the server table, for example, EDGE.
Under the More dropdown button, you should be able to queue updates for this particular type and any CDN.
Do a similar test for profiles.

If this is a bug fix, what versions of Traffic Control are affected?

master

The following criteria are ALL met by this PR

This PR includes tests
This PR includes documentation
This PR includes an update to CHANGELOG.md
This PR includes any and all required license headers
This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

rawlinp

Code and tests look good, just noticed a small UI issue.

EDIT: there is also a merge conflict in CHANGELOG.md that needs to be resolved

rawlinp · 2021-07-19T16:22:43Z

These TP test failures might be related to this PR:

Failures:
1) Traffic Portal - CDN - Admin Role queue CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

2) Traffic Portal - CDN - Admin Role clear CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

3) Traffic Portal - CDN - Operation Role queue CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

4) Traffic Portal - CDN - Operation Role clear CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

490 specs, 4 failures

…trol into CDN-13414

srijeet0406 · 2021-07-19T18:01:11Z

These TP test failures might be related to this PR:

Failures:
1) Traffic Portal - CDN - Admin Role queue CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

2) Traffic Portal - CDN - Admin Role clear CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

3) Traffic Portal - CDN - Operation Role queue CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

4) Traffic Portal - CDN - Operation Role clear CDN updates
  Message:
    Expected false to be truthy.
  Stack:
    Error: Failed expectation
        at Suite.<anonymous> (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/specs/CDNs.spec.ts:57:62)
        at Generator.next (<anonymous>)
        at fulfilled (/home/runner/go/src/github.com/apache/trafficcontrol/traffic_portal/test/integration/GeneratedCode/specs/CDNs.spec.js:5:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

490 specs, 4 failures

Fixed now

rawlinp reviewed Jul 12, 2021

View reviewed changes

Comment thread traffic_ops/traffic_ops_golang/routing/routes.go Outdated

rawlinp added new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops labels Jul 12, 2021

srijeet0406 added 5 commits July 12, 2021 15:09

wip

6599ab7

Adding tests

8ed303c

fix documentation

2eacda7

fix documentation

7572fc2

fix imports, add go docs

ba102ea

srijeet0406 force-pushed the CDN-13414 branch from 5d8119e to ba102ea Compare July 12, 2021 21:09

use pre existing route, instead of creating a new one

4758bb2

rawlinp suggested changes Jul 15, 2021

View reviewed changes

Comment thread traffic_ops/v4-client/server_update_status.go Outdated

Comment thread traffic_ops/traffic_ops_golang/cdn/queue.go Outdated

Comment thread lib/go-tc/servers.go Outdated

Comment thread traffic_portal/app/src/common/modules/form/type/form.type.tpl.html Outdated

code review fixes

5e01d12

rawlinp suggested changes Jul 16, 2021

View reviewed changes

Comment thread traffic_ops/testing/api/v4/cdn_queue_updates_by_type_profile_test.go

Comment thread traffic_ops/testing/api/v4/cdn_queue_updates_by_type_profile_test.go

Comment thread traffic_ops/traffic_ops_golang/cdn/queue.go

Comment thread docs/source/api/v4/cdns_id_queue_update.rst Outdated

code review changes

c3102d3

rawlinp suggested changes Jul 19, 2021

View reviewed changes

Comment thread traffic_portal/app/src/common/modules/form/type/form.type.tpl.html Outdated

srijeet0406 and others added 2 commits July 19, 2021 09:45

move UI button to right

8a45539

Merge branch 'master' into CDN-13414

aaa4fcd

rawlinp added the Traffic Portal v1 related to Traffic Portal version 1 label Jul 19, 2021

rawlinp approved these changes Jul 19, 2021

View reviewed changes

srijeet0406 added 2 commits July 19, 2021 11:31

do not throw an error if no servers matched the criteria

7a276b6

Merge branch 'CDN-13414' of https://github.com/srijeet0406/trafficcon…

9d1859f

…trol into CDN-13414

rawlinp merged commit 8523a6e into apache:master Jul 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support queueing updates by type and profile#6014

Support queueing updates by type and profile#6014
rawlinp merged 12 commits intoapache:masterfrom
srijeet0406:CDN-13414

srijeet0406 commented Jul 12, 2021 •

edited by rawlinp

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rawlinp left a comment •

edited

Loading

Uh oh!

Uh oh!

rawlinp commented Jul 19, 2021

Uh oh!

srijeet0406 commented Jul 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

srijeet0406 commented Jul 12, 2021 • edited by rawlinp Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

Additional Information

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rawlinp left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rawlinp commented Jul 19, 2021

Uh oh!

srijeet0406 commented Jul 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

srijeet0406 commented Jul 12, 2021 •

edited by rawlinp

Loading

rawlinp left a comment •

edited

Loading