Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

updating all APi 1.x endpoints to 2.0 for compatibility#6059

Merged
zrhoffman merged 14 commits intoapache:masterfrom
ragen14:api1-to-2
Jul 30, 2021
Merged

updating all APi 1.x endpoints to 2.0 for compatibility#6059
zrhoffman merged 14 commits intoapache:masterfrom
ragen14:api1-to-2

Conversation

@ragen14
Copy link
Copy Markdown
Contributor

@ragen14 ragen14 commented Jul 26, 2021

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Ansible Infrastructure code

What is the best way to verify this PR?

Best way to verify the change is to build CDN infra using the Ansible playbook in infrastructure/ dir

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GET /cdns/{{name}}/snapshot/new still uses API v1:

url: "{{ to_api_base_url }}/api/1.2/cdns/{{ to_api_target_cdn }}/snapshot/new"

@ragen14
Copy link
Copy Markdown
Contributor Author

ragen14 commented Jul 26, 2021

woops!!.. done

Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread infrastructure/ansible/roles/to_api/tasks/set_server_status.yml Outdated
Comment thread infrastructure/ansible/roles/dataset_loader/defaults/main.yml Outdated
Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but the PR still needs to be tested.

@zrhoffman zrhoffman added this to the TO API v1 removal milestone Jul 27, 2021
@mitchell852 mitchell852 added ansible Related to the Ansible roles automation related to automated testing/deployment/packaging etc. improvement The functionality exists but it could be improved in some way. labels Jul 28, 2021
Comment thread infrastructure/ansible/roles/dataset_loader/templates/server.j2 Outdated
Comment thread infrastructure/ansible/roles/dataset_loader/templates/server.j2 Outdated
Comment thread infrastructure/ansible/roles/dataset_loader/tasks/update_mso_servers.yml Outdated
Comment thread infrastructure/ansible/roles/dataset_loader/tasks/update_mso_servers.yml Outdated
Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing confirms that it works!

Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a changelog merge conflict from #6073.

Comment thread infrastructure/ansible/roles/dataset_loader/defaults/main.yml Outdated
Comment thread infrastructure/ansible/roles/dataset_loader/tasks/dataset_loader.yml Outdated
@zrhoffman zrhoffman merged commit 9f17e2e into apache:master Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ansible Related to the Ansible roles automation related to automated testing/deployment/packaging etc. improvement The functionality exists but it could be improved in some way.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ansible playbooks still use Traffic Ops API v1

4 participants