This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Run goose~schema_migrations trigger after UPDATE, not INSERT#6134
Merged
rawlinp merged 1 commit intoapache:masterfrom Aug 23, 2021
Merged
Run goose~schema_migrations trigger after UPDATE, not INSERT#6134rawlinp merged 1 commit intoapache:masterfrom
rawlinp merged 1 commit intoapache:masterfrom
Conversation
zrhoffman
added
bug
Member
Author
|
DB tests failed because IMO the "right order" check should only be for added files, not for modified files. |
rawlinp
approved these changes
Aug 23, 2021
zrhoffman
added a commit
that referenced
this pull request
Aug 30, 2021
(cherry picked from commit 2b7c52e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #6127 by keeping the
schema_migrationstable'sversioncolumn in-sync by running thefast_forward_schema_migrations_triggertrigger in00000000000000_init.upmigration after a row of theschema_migrationstable is updated, not after a row is inserted.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the Traffic Ops DB tests using a database dump from the ATC 5.1.2 release (and using a traffic Ops RPM built at 8b05a7b).
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist