Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Make t3c request less unnecessary DSS and jobs data#6186

Merged
ocket8888 merged 1 commit intoapache:masterfrom
rawlinp:t3c-new-qparams
Sep 10, 2021
Merged

Make t3c request less unnecessary DSS and jobs data#6186
ocket8888 merged 1 commit intoapache:masterfrom
rawlinp:t3c-new-qparams

Conversation

@rawlinp
Copy link
Copy Markdown
Contributor

@rawlinp rawlinp commented Sep 9, 2021

Use the new query parameters supported by Traffic Ops to reduce the
amount of unnecessary data requested from the /deliveryserviceserver and
/jobs APIs.

Also, fix the CIAB t3c cron job to actually run and send output to /var/log/ort.log.

Closes: #5674
Closes: #6034


Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (T3C, formerly ORT)
  • CDN in a Box

What is the best way to verify this PR?

Ensure the GHA CI passes, build CIAB and docker exec -it <edge/mid-01/mid-02 container> bash to view the generated ATS config files in /opt/trafficserver/etc/trafficserver, submit an invalidation for the demo1 DS via TP, wait for regex_revalidate.config to be updated, and ensure it contains the submitted invalidation (it will first update on mid-02, mid-01, then edge). This will indicate that t3c's GET /jobs request is working properly. Create a new DS w/ type HTTP_NO_CACHE, assign it to the edge server, and queue updates. In the edge container, check remap.config to ensure there is a new entry for the DS. This will indicate that t3c's GET /deliveryserviceserver request is working properly.

PR submission checklist

  • This PR does not add any tests because there don't appear to be any unit tests around how t3c makes requests to TO, and I assume the cache-config integration tests pretty much cover t3c making requests to TO. Additionally, I performed manual testing in CIAB.
  • Performance enhancement, no docs necessary
  • This PR has a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Use the new query parameters supported by Traffic Ops to reduce the
amount of unnecessary data requested from the /deliveryserviceserver and
/jobs APIs.

Closes: apache#5674
Closes: apache#6034
@rawlinp rawlinp added performance impacts/improves/measures performance cache-config Cache config generation labels Sep 9, 2021
Copy link
Copy Markdown
Contributor

@jrushford jrushford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good passes testing

@ocket8888 ocket8888 merged commit fe27e7e into apache:master Sep 10, 2021
@rawlinp rawlinp deleted the t3c-new-qparams branch September 10, 2021 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cache-config Cache config generation performance impacts/improves/measures performance

Projects

None yet

3 participants