Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Dont start Riak in TP/TO GHA#6188

Merged
zrhoffman merged 7 commits intoapache:masterfrom
shamrickus:gha/stop-riak
Sep 10, 2021
Merged

Dont start Riak in TP/TO GHA#6188
zrhoffman merged 7 commits intoapache:masterfrom
shamrickus:gha/stop-riak

Conversation

@shamrickus
Copy link
Copy Markdown
Member

This PR fixes #5946 and #5947


Which Traffic Control components are affected by this PR?

  • Automation (GHA)

What is the best way to verify this PR?

Inspect the logs and make sure traffic vault is not running. For TP, look at the artifacts and ensure that tv.log does not exist.

PR submission checklist

@zrhoffman zrhoffman added automation related to automated testing/deployment/packaging etc. improvement The functionality exists but it could be improved in some way. tech debt rework due to choosing easy/limited solution tests related to tests and/or testing infrastructure labels Sep 9, 2021
Comment thread .github/actions/tvdb-init/README.md Outdated
Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer provides a Riak server

- Provides a Riak server at address `trafficvault.infra.ciab.test`

There is no longer a Riak server

- provides a riak server at address `trafficvault.infra.ciab.test`

Is inserting a RIAK server still necessary?

WITH TYPE AS (SELECT id FROM type WHERE name = 'RIAK'),
PROFILE AS (SELECT id FROM profile WHERE name = 'RIAK_ALL'),
STATUS AS (SELECT id FROM status WHERE name = 'ONLINE'),
PHYS AS (SELECT id FROM phys_location WHERE name = '${PHYS}'),
CDN AS (SELECT id FROM cdn WHERE name = '${CDN}'),
CG AS (SELECT id from cachegroup WHERE name = '${CG}')
INSERT INTO server(host_name, domain_name, cachegroup, type, status, profile, phys_location, cdn_id)
SELECT 'trafficvault', 'infra.ciab.test', CG.ID, TYPE.id, STATUS.id, PROFILE.id, PHYS.id, CDN.id
FROM TYPE
JOIN STATUS ON 1=1
JOIN PROFILE ON 1=1
JOIN PHYS ON 1=1
JOIN CDN ON 1=1
JOIN CG ON 1=1;

No need to gitignore riak.conf

Comment thread .github/actions/to-integration-tests/cdn.json
Comment thread .github/workflows/tp.integration.tests.yml
Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow didn't see the existing reviewer. The two things I pointed out weren't real, so I'm bowing out now.

Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Verified that Traffic Vault is not running, and, for TP, no traffic_vault.log file exists in the artifact on failure.

@zrhoffman zrhoffman merged commit d0041a9 into apache:master Sep 10, 2021
zrhoffman pushed a commit that referenced this pull request Sep 22, 2021
* Dont start riak

* Remove riak.json

* Forgot to remove riak.json

* More TP cleanup

* Forgot more TP

* Fix typo

* Remove more references to riak

(cherry picked from commit d0041a9)
@zrhoffman zrhoffman linked an issue Oct 12, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automation related to automated testing/deployment/packaging etc. improvement The functionality exists but it could be improved in some way. tech debt rework due to choosing easy/limited solution tests related to tests and/or testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TP Integration Tests GHA still starts Riak container TO API Tests GHA still starts Riak container

3 participants