This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Dont start Riak in TP/TO GHA#6188
Merged
zrhoffman merged 7 commits intoapache:masterfrom Sep 10, 2021
shamrickus:gha/stop-riak
Merged
Dont start Riak in TP/TO GHA#6188zrhoffman merged 7 commits intoapache:masterfrom shamrickus:gha/stop-riak
zrhoffman merged 7 commits intoapache:masterfrom
shamrickus:gha/stop-riak
Conversation
zrhoffman
suggested changes
Sep 9, 2021
zrhoffman
suggested changes
Sep 10, 2021
Member
zrhoffman
left a comment
There was a problem hiding this comment.
No longer provides a Riak server
There is no longer a Riak server
Is inserting a RIAK server still necessary?
trafficcontrol/.github/actions/tp-integration-tests/entrypoint.sh
Lines 90 to 103 in 6790479
No need to gitignore riak.conf
ocket8888
reviewed
Sep 10, 2021
ocket8888
approved these changes
Sep 10, 2021
Contributor
ocket8888
left a comment
There was a problem hiding this comment.
Somehow didn't see the existing reviewer. The two things I pointed out weren't real, so I'm bowing out now.
zrhoffman
approved these changes
Sep 10, 2021
Member
zrhoffman
left a comment
There was a problem hiding this comment.
Looks good! Verified that Traffic Vault is not running, and, for TP, no traffic_vault.log file exists in the artifact on failure.
zrhoffman
pushed a commit
that referenced
this pull request
Sep 22, 2021
* Dont start riak * Remove riak.json * Forgot to remove riak.json * More TP cleanup * Forgot more TP * Fix typo * Remove more references to riak (cherry picked from commit d0041a9)
This was referenced Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #5946 and #5947
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Inspect the logs and make sure traffic vault is not running. For TP, look at the artifacts and ensure that
tv.logdoes not exist.PR submission checklist