Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add TO Client API for Delivery Services Required Capabilities#6233

Merged
ocket8888 merged 2 commits intoapache:masterfrom
dmohan001c:dsrcautomation
Oct 11, 2021
Merged

Add TO Client API for Delivery Services Required Capabilities#6233
ocket8888 merged 2 commits intoapache:masterfrom
dmohan001c:dsrcautomation

Conversation

@dmohan001c
Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • Traffic Control Client
  • Traffic Ops
  • CI tests

What is the best way to verify this PR?

Execute all the Integration tests and make sure the tests are passed.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@dmohan001c dmohan001c closed this Sep 22, 2021
@dmohan001c dmohan001c reopened this Sep 22, 2021
@ocket8888 ocket8888 added improvement The functionality exists but it could be improved in some way. tests related to tests and/or testing infrastructure TO Client (Go) related to the Go implementation of a TC client labels Sep 24, 2021
}
]
}
} No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline at EOF

Though honestly all of these changes seem cosmetic, so you could also just not change the file at all

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added newline at end of file, those changes are auto-formatted automatically.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but we have no prescribed auto-formatter or auto-formatting settings. Someone else's auto-formatting might change them all back. It's not a big enough deal to hold up this PR, it's just changes that didn't need to be made.

@ocket8888 ocket8888 merged commit 5985a56 into apache:master Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

improvement The functionality exists but it could be improved in some way. tests related to tests and/or testing infrastructure TO Client (Go) related to the Go implementation of a TC client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants