This repository was archived by the owner on Nov 24, 2025. It is now read-only.
t3c setting mode 0600 for secure files#6240
Merged
ocket8888 merged 46 commits intoapache:masterfrom Nov 9, 2021
Merged
Conversation
…e cfg.Perm variable.
…ded func to compare file permissions.
jrushford
approved these changes
Nov 9, 2021
Contributor
jrushford
left a comment
There was a problem hiding this comment.
The code looks good to me. Passes unit and integration tests. Ran t3c in badass mode and all secure files were created with permissions 0600
ocket8888
reviewed
Nov 9, 2021
ocket8888
approved these changes
Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #6032
As described in the issue files designated secure will be written with 0600 permissions.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Build an rpm, install it on an admin_down or lab cache, queue updates and run t3c in apply mode.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist