This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix notification text in production environments not visible/accessible#6258
Merged
shamrickus merged 4 commits intoapache:masterfrom Oct 7, 2021
Merged
Conversation
Also removes a ton of redundant and/or unused rules and/or selectors
ocket8888
added
bug
shamrickus
approved these changes
Oct 7, 2021
Member
shamrickus
left a comment
shamrickus
left a comment
There was a problem hiding this comment.
LGTM
- Both prod mode and non look as they should.
zrhoffman
pushed a commit
that referenced
this pull request
Oct 7, 2021
…le (#6258) * Fix unreadable/inaccessible CDN notification text in prod environments Also removes a ton of redundant and/or unused rules and/or selectors * Fix double-highlighting menu items * Remove a bunch of duplicate/ineffectual rules/selectors and uses of !important * Update CHANGELOG (cherry picked from commit b02bbe7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #6255
It also removes a bunch of rules that were redundant, unused, and/or ineffectual, and simplifies the header's styling by using scss rule nesting.
I also removed a few more instances of
!important, many of which appeared to exist only to override other instances of!important. In doing so, I believe I fixed a bug where the active menu item's color in the sidebar was not changing to match the indicator strip, which caused sidebar links being hovered to be styled exactly like sidebar links that were active.This also fixes some invalid HTML I found in the sidebar
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
start up traffic portal in a production environment, verify that all text in the header is visible with sufficient contrast to the background.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist