Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Quote spaces in env file values#6265

Merged
shamrickus merged 1 commit intoapache:masterfrom
zrhoffman:key-space
Oct 11, 2021
Merged

Quote spaces in env file values#6265
shamrickus merged 1 commit intoapache:masterfrom
zrhoffman:key-space

Conversation

@zrhoffman
Copy link
Copy Markdown
Member

@zrhoffman zrhoffman commented Oct 11, 2021

This PR fixes #6264 by quoting values in CDN in a Box's env file that contain spaces.


Which Traffic Control components are affected by this PR?

  • CDN in a Box

What is the best way to verify this PR?

  1. Get docker-compose 2.0.1
  2. cd infrastructure/cdn-in-a-box
    docker-compose ps --services

Expected output (for docker-compose 2.0.1 only):

[user@computer cdn-in-a-box]$ docker-compose ps --services

If this is a bugfix, which Traffic Control versions contained the bug?

  • 6.0.0 (RC4)
  • 5.1.3 (RC0)
  • master@5985a56

PR submission checklist

@zrhoffman zrhoffman added bug something isn't working as intended cdn-in-a-box related to the Docker-based CDN-in-a-Box system labels Oct 11, 2021
Copy link
Copy Markdown
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Fixes issues with docker 2.0.1

@shamrickus shamrickus merged commit 6ee04dd into apache:master Oct 11, 2021
@ocket8888
Copy link
Copy Markdown
Contributor

Fwiw there's an issue open against docker-compose to fix this behavior

@zrhoffman zrhoffman deleted the key-space branch October 11, 2021 18:11
@zrhoffman zrhoffman added this to the 6.0.1 milestone Nov 5, 2021
zrhoffman added a commit that referenced this pull request Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended cdn-in-a-box related to the Docker-based CDN-in-a-Box system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CiaB with docker-compose 2.0.1: key cannot contain a space

3 participants