This repository was archived by the owner on Nov 24, 2025. It is now read-only.
POST request to /api/4.0/phys_locations accepts mismatch values for regionName#6269
Merged
mattjackson220 merged 2 commits intoapache:masterfrom Oct 19, 2021
Merged
POST request to /api/4.0/phys_locations accepts mismatch values for regionName#6269mattjackson220 merged 2 commits intoapache:masterfrom
mattjackson220 merged 2 commits intoapache:masterfrom
Conversation
Member
srijeet0406
force-pushed
the
CDN-14367
branch
2 times, most recently
from
2f9813d to
44a151a
Compare
Contributor
|
Needs another rebase to pull in #6290. |
mattjackson220
approved these changes
Oct 15, 2021
Contributor
mattjackson220
left a comment
mattjackson220
left a comment
There was a problem hiding this comment.
Looks good to me! Code looks good, tests pass, tested locally and works as expected! I'll merge it after a rebase and the checks pass
srijeet0406
force-pushed
the
CDN-14367
branch
from
44a151a to
0dee601
Compare
ocket8888
added
bug
Contributor
|
@mattjackson220 you wanna merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #6175
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure all the tests pass.
Follow the instructions in #6175
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist