TP: replace compass/ruby#6278
TP: replace compass/ruby#6278ocket8888 merged 12 commits intoapache:masterfrom shamrickus:tp/remove-ruby
Conversation
ocket8888
left a comment
There was a problem hiding this comment.
The grunt watch task still references "compass", which means that live-reloading (or what passes for it in AngularJS) is currently broken on this branch.
ocket8888
left a comment
There was a problem hiding this comment.
Changes look good, UI appears unchanged, RPMs build fine
As noted in the PR description, actions are expected to fail due to bad published images on Dockerhub. The changes in this PR include a fix for that, but they can't be updated until it's merged.
Our build-rpms action checks for whether the trafficcontrol/.github/actions/build-rpms/build-rpms.sh Lines 33 to 35 in 1f56100 So the action would pass if you added the TP builder Dockerfile to the list of files to check for, in addition to GO_VERSION (see #6210, which adds the TR builder Dockerfile). |
* Replace compass with dart-sass * Wrong sass * Wrong sass * More removals * Changelog * Cleanup * Use exact versioning * Remove other ruby deps * Fix docs * Fix docs * Fix docs * Fix watch (cherry picked from commit 8ce81f5)
This PR changes the TP sass compiler from
compass(deprecated) todart-sass(official sass compiler). As a result, ruby is no longer a dependency of TP.It also changes the TP build docker file to always install nodejs 12.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Note: CiaB (and associated CI) for TP build will always fail (until merged) as it is using the dockerhub TP image, which was built using nodejs 10.
gulp-dart-sassrequires nodejs 12.Build TP locally and confirm that it works.
Build TP using
pkgwith the-bcommand (so it uses the correct nodejs version).Verify that TP looks correct.
Check the docs and make sure
ruby/compassare no longer mentioned.It is also possible to diff
dist/resources/stylesand see that the CSS is mostly the same with a few exceptions. First, sourceMaps are now specified by comments instead of through media queries. Second, thecompassminification doesn't remove some chars thatdart-sassdoes, as a result the new CSS should always be at least as small.PR submission checklist