This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Reduce DNSSEC refresh change log noise#6279
Merged
dneuman64 merged 1 commit intoapache:masterfrom Oct 18, 2021
Merged
Conversation
rawlinp
added
Traffic Ops
Contributor
Author
|
For some reason, the TP tests are failing to get past the initialize stage, and it seems to be an issue unrelated to this PR. |
Member
rawlinp
force-pushed
the
fix-dnssec-refresh-cl
branch
from
ec334ea to
3a43b9d
Compare
srijeet0406
approved these changes
Oct 14, 2021
Contributor
srijeet0406
left a comment
srijeet0406
left a comment
There was a problem hiding this comment.
Hit the cdns/dnsseckeys/refresh api endpoint back to back and made sure that changelog msgs were not getting generated.
All tests pass, code looks good.
Contributor
|
@rawlinp You might need to rebase for the GHA TP tests to pass. |
Only create a changelog entry if any keys actually changed or an error occurred. Also, differentiate between errors storing into Traffic Vault and other types of errors. Closes: apache#6268
rawlinp
force-pushed
the
fix-dnssec-refresh-cl
branch
from
3a43b9d to
0025023
Compare
Contributor
Author
|
Rebased! |
Contributor
|
You're gonna need to do it again to get #6290 in your branch |
Contributor
Author
|
@ocket8888 I did, but hit another spurious TP test failure (unrelated to this PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only create a changelog entry if any keys actually changed or an error
occurred. Also, differentiate between errors storing into Traffic Vault
and other types of errors.
Closes: #6268
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Attempt to refresh the DNSSEC keys in quick succession. If there are no keys refreshed, there should be no change log entry created.
If this is a bugfix, which Traffic Control versions contained the bug?
6.0.0
PR submission checklist