Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix to error message not being displayed if error occurs while removing a server from a ds#6280

Merged
rawlinp merged 2 commits intoapache:masterfrom
mitchell852:tp-broken-error-msg
Oct 20, 2021
Merged

Fix to error message not being displayed if error occurs while removing a server from a ds#6280
rawlinp merged 2 commits intoapache:masterfrom
mitchell852:tp-broken-error-msg

Conversation

@mitchell852
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 commented Oct 13, 2021 •
edited
Loading

This PR (no issue) fixes an error message not being displayed if there is an error when trying to remove a server from a DS

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Find an MSO delivery service and assign 2 ORG servers, then try to remove both of them. You'll get an error because an MSO delivery service requires at least 1 ORG server. The error message should display in TP.

If this is a bugfix, which Traffic Control versions contained the bug?

  • 5.1.3
  • 6.0.0

PR submission checklist

  • This PR has tests
  • This PR has documentation
  • This PR has a CHANGELOG.md entry <!-- This bug is so tiny i don't think a change log entry is warranted
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@zrhoffman
Copy link
Copy Markdown
Member

zrhoffman commented Oct 14, 2021

#6280's TP GHA failed due to #6283 needs to be rebased onto master now that #6284 is merged in order to pass

@mitchell852 mitchell852 added this to the 6.0.1 milestone Oct 18, 2021
@ocket8888 ocket8888 added bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1 labels Oct 19, 2021
@rawlinp rawlinp merged commit efed598 into apache:master Oct 20, 2021
zrhoffman pushed a commit that referenced this pull request Nov 5, 2021
@mitchell852 @zrhoffman
Fix to error message not being displayed if error occurs while removi…
b8c46b7 
…ng a server from a ds (#6280)

* fixes missing space

* fixes error message not being displayed

(cherry picked from commit efed598)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rawlinp rawlinp rawlinp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Milestone

6.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@mitchell852 @zrhoffman @rawlinp @ocket8888