This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Added SANs to Cert Page#6282
Merged
shamrickus merged 3 commits intoapache:masterfrom Oct 15, 2021
Merged
Conversation
mattjackson220
added
Traffic Ops
Member
mattjackson220
force-pushed
the
SansOnCertPage
branch
from
8f68a4d to
876765b
Compare
shamrickus
suggested changes
Oct 15, 2021
Member
|
Also it looks like your rebase didn't pick up the #6284 fixes. |
mattjackson220
force-pushed
the
SansOnCertPage
branch
from
fd2aa20 to
920e79c
Compare
shamrickus
approved these changes
Oct 15, 2021
Member
shamrickus
left a comment
shamrickus
left a comment
There was a problem hiding this comment.
LGTM
- API/TP show SANs for a cert if relevant.
rawlinp
reviewed
Oct 15, 2021
rawlinp
added a commit
to rawlinp/trafficcontrol
that referenced
this pull request
Oct 18, 2021
The 4.0 TO API version is currently considered unstable and under development, so the addition of a 4.1 TO API version was unnecessary. New TO API changes can currently be made to 4.0. This is a follow-up to apache#6282 which included the addition of 4.1.
4 tasks
mattjackson220
pushed a commit
that referenced
this pull request
Oct 18, 2021
The 4.0 TO API version is currently considered unstable and under development, so the addition of a 4.1 TO API version was unnecessary. New TO API changes can currently be made to 4.0. This is a follow-up to #6282 which included the addition of 4.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the SANs information from a certificate to the
deliveryservices/xmlId/{xmlid}/sslkeysendpoint in Traffic Ops and the certificate page in Traffic PortalWhich Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Create a certificate that has SANs and add it to a delivery service (or use one that already exists)
Verify that on the certificate page in TP there is a field for the SANs and that it is filled in appropriately.
Verify that the
deliveryservices/xmlId/{xmlid}/sslkeysendpoint returns the SANs for API version 4.1 but does not for any previous versionVerify that the TO tests pass
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist